Fixed initial value of number input in recorder configuration.

jenkinsci · Jun 20, 2018 · 62cf234 · 62cf234
1 parent ca611d6
commit 62cf234
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 17 deletions.
diff --git a/src/main/resources/issues/number.jelly b/src/main/resources/issues/number.jelly
@@ -48,7 +48,7 @@
   <j:set var="name" value="${attrs.name ?: '_.'+attrs.field}"/>
   <j:set var="default" value="${attrs.default ?: ''}"/>
   <j:set var="value" value="${attrs.value ?: instance[attrs.field] ?: default}"/>
-  <j:set var="positiveValue" value="${value > 0?: null}"/>
+  <j:set var="positiveValue" value="${value > 0? value : null}"/>
   <m:input xmlns:m="jelly:hudson.util.jelly.MorphTagLibrary"
            class="setting-input ${attrs.checkUrl!=null?'validated':''} ${attrs.clazz}"
            name="${name}"

diff --git a/src/main/resources/issues/thresholds-total.jelly b/src/main/resources/issues/thresholds-total.jelly
@@ -22,20 +22,16 @@
                title="${%description.unstableTotal}"/>
         </td>
         <td>
-          <i:number name="unstableTotalAll"
-                     value="${instance.thresholds.unstableTotalAll}"/>
+          <i:number field="unstableTotalAll"/>
         </td>
         <td>
-          <i:number name="unstableTotalHigh"
-                     value="${instance.thresholds.unstableTotalHigh}"/>
+          <i:number field="unstableTotalHigh"/>
         </td>
         <td>
-          <i:number name="unstableTotalNormal"
-                     value="${instance.thresholds.unstableTotalNormal}"/>
+          <i:number field="unstableTotalNormal"/>
         </td>
         <td>
-          <i:number name="unstableTotalLow"
-                     value="${instance.thresholds.unstableTotalLow}"/>
+          <i:number field="unstableTotalLow"/>
         </td>
       </tr>
       <tr>
@@ -44,20 +40,16 @@
                title="${%description.failedTotal}"/>
         </td>
         <td>
-          <i:number name="failedTotalAll"
-                     value="${instance.thresholds.failedTotalAll}"/>
+          <i:number field="failedTotalAll"/>
         </td>
         <td>
-          <i:number name="failedTotalHigh"
-                     value="${instance.thresholds.failedTotalHigh}"/>
+          <i:number field="failedTotalHigh"/>
         </td>
         <td>
-          <i:number name="failedTotalNormal"
-                     value="${instance.thresholds.failedTotalNormal}"/>
+          <i:number field="failedTotalNormal"/>
         </td>
         <td>
-          <i:number name="failedTotalLow"
-                     value="${instance.thresholds.failedTotalLow}"/>
+          <i:number field="failedTotalLow"/>
         </td>
       </tr>
     </tbody>