Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the package id is set in the uninstall configure. #53

Merged
merged 1 commit into from Dec 3, 2017
Merged

Check the package id is set in the uninstall configure. #53

merged 1 commit into from Dec 3, 2017

Conversation

hunkim
Copy link
Contributor

@hunkim hunkim commented Jul 18, 2015

It would be nice to give users a heads up in the configure rather than running 'perform' and giving them an error in the build.

Since we are already checking the existence of package id, and give an error:

Uninstall.java
// Check whether a value was provided
final String packageId = getPackageId();
if (Util.fixEmptyAndTrim(packageId) == null) {
AndroidEmulator.log(logger, Messages.PACKAGE_ID_NOT_SPECIFIED());
return false;
}

We can check that in the configure in advance.

This patch will bring a nice note in configure, and check the input.

screenshot 2015-07-18 13 19 00

It would be nice to give users head ups in the configure rather than running 'perform' and giving them an error.
@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@orrc orrc self-assigned this Nov 14, 2017
@orrc
Copy link
Member

orrc commented Dec 3, 2017

Thanks!

@orrc orrc merged commit 4a246e1 into jenkinsci:master Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants