JENKINS-57341 - Update plugin archetype for Java 11 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base on the latest long term support release so that the plugin author can choose to develop with either Java 8 or Java 11.
Parent pom versions prior to 3.43 do not have correct settings for javadoc generation.
Use parent pom 3.43 and require Jenkins version 2.164.1. That will allow development with either Java 8 or Java 11.
workflow-support 3.2 is required for Java 11 compile. Adding workflow-support 3.2 requires script-security and scm-api. workflow-api 2.30 and workflow-step-api 2.19 required for upper bounds dependencies. structs 1.18 for upper bounds dependencies
|
I don't understand why the pull request build is failing. I've run it on my Debian 10 machine with Java 8 update 212 and it runs successfully. It fails with Java 11 on my Debian 10 machine, but the docker image is Java 8, so that failure seems unlikely to be happening here. Still no hint why the job fails on the CI server and passes consistently with the same command in my environment. The |
Maven 3.5.4 includes changes for Java 11 compatibility.
jglick
reviewed
Jun 18, 2019
|
When I get a chance I can try to reproduce the test error. |
jglick
reviewed
Jun 19, 2019
|
After this gets merged, @oleg-nenashev I guess we can set up @dependabot here? At least I think it will offer to update the parent POM versions. |
|
After this gets merged, @oleg-nenashev <https://github.com/oleg-nenashev> I
guess we can set up @dependabot <https://github.com/dependabot> here? At
least I think it will offer to update the parent POM versions
Yes, we can
…On Wed, Jun 19, 2019, 05:23 Mark Waite ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In hello-world/src/main/resources/archetype-resources/pom.xml
<#41 (comment)>:
> <scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins.workflow</groupId>
<artifactId>workflow-support</artifactId>
- <version>2.14</version>
+ <version>3.2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.jenkins-ci.plugins</groupId>
+ <artifactId>script-security</artifactId>
I've moved it to dependencyManagement in hopes that I've understood your
intention. I'm afraid that I don't really understand maven well enough to
be sure I did it correctly. Let me know if I've gone the wrong direction
with the change.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41?email_source=notifications&email_token=AAW4RIHCMB3FMDS7EXZT3R3P3GRC3A5CNFSM4HLAHTB2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB36O5RI#discussion_r295107249>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW4RIGBU4DSJX7F6BLV3ILP3GRC3ANCNFSM4HLAHTBQ>
.
|
…llow-java-11-not-java-7
jglick
approved these changes
Jun 19, 2019
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>script-security</artifactId> | ||
| <version>1.39</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
I think you can omit the scope here, but it is probably fine.
oleg-nenashev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-57341 Update plugin archetype for Java 11
Update jenkins.version and java.level so that plugins generated from the archetype support Java 8 and Java 11.
Update other dependencies to allow Java 8 and Java 11.