Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of AWS SSO at least in tests #351

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Allow use of AWS SSO at least in tests #351

merged 2 commits into from
Jan 20, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 20, 2023

Fixing error diagnosed better in #350. Taking hints from aws/aws-sdk-java#2434 (comment) + aws/aws-sdk-java#803 (comment). For now limited to functional tests, assuming this is not useful in production servers.

@jglick jglick added the tests label Jan 20, 2023
@jglick

This comment was marked as resolved.

Sign in to view
@jglick
Copy link
Member Author

jglick commented Jan 20, 2023

Getting a test failure locally, but probably unrelated:

com.amazonaws.services.s3.model.AmazonS3Exception: Access Denied (Service: Amazon S3; Status Code: 403; Error Code: AccessDenied; Request ID: …; S3 Extended Request ID: …; Proxy: null), S3 Extended Request ID: …
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleErrorResponse(AmazonHttpClient.java:1879)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.handleServiceErrorResponse(AmazonHttpClient.java:1418)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeOneRequest(AmazonHttpClient.java:1387)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:1157)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:814)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:781)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:755)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:715)
	at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:697)
	at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:561)
	at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:541)
	at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5456)
	at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5403)
	at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5397)
	at com.amazonaws.services.s3.AmazonS3Client.listObjectsV2(AmazonS3Client.java:971)
	at com.amazonaws.services.s3.AmazonS3Client.listObjectsV2(AmazonS3Client.java:940)
	at io.jenkins.plugins.artifact_manager_jclouds.s3.JCloudsVirtualFileTest.testAmpersand(JCloudsVirtualFileTest.java:291)

@jglick
Copy link
Member Author

jglick commented Jan 20, 2023

Passes CI using instance identity.

@jglick jglick marked this pull request as ready for review January 20, 2023 21:08
dwnusbaum
dwnusbaum approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me locally.

@jglick jglick merged commit 0e0e95d into jenkinsci:master Jan 20, 2023
@jglick jglick deleted the SSO branch January 20, 2023 21:43
@jglick jglick mentioned this pull request Jul 18, 2023
Merged
@jglick jglick mentioned this pull request Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@Vlatombe Vlatombe Awaiting requested review from Vlatombe

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
2 participants
@jglick @dwnusbaum