Fix inconsistent users issue #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #34
The security advisory helps to expose an existing bug here.
Summary problem here is that when validate seed for current user, this plugin refers to different user ids in session and authentication.
The new seed security listener uses UserDetails#getUsername() to fetch a user which is implemented by AzureAdUser#getUsername() returning the user name of a azure ad user.
In the HttpSessionContextIntegrationFilter2#hasInvalidSessionSeed() method, it gets a user by Authentication#getName() which is implemented in AzureAuthenticationToken#getName() returning the unique name of the azure ad user.
UserDetails#getUsername() returns the username to authenticate the user, so it should also be unique. I also refactored the former username variable to name to make consistent with previous version.