Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth token to http clone link #810

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

andrey-fomin
Copy link
Contributor

@andrey-fomin andrey-fomin commented Feb 14, 2024

Problem was introduced in #796. Fixes #808.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

It's hard to write test for BitbucketOAuthAuthenticator because of statically called service methods.

@andrey-fomin
Copy link
Contributor Author

Hi @rgrizzell
I see the auth token is visible in the console output. Was it the case previously?

@rgrizzell
Copy link

Hi @rgrizzell I see the auth token is visible in the console output. Was it the case previously?

Yes, on version 866.vdea_7dcd3008e, the Auth Token is printed to console output. It looks something like: https://x-token-auth:{*****}@bitbucket.org/*****/*****.git

@andrey-fomin
Copy link
Contributor Author

andrey-fomin commented Feb 15, 2024

Hi @rgrizzell I see the auth token is visible in the console output. Was it the case previously?

Yes, on version 866.vdea_7dcd3008e, the Auth Token is printed to console output. It looks something like: https://x-token-auth:{*****}@bitbucket.org/*****/*****.git

Thanks. Then this fix should be ok.

@lifeofguenter lifeofguenter added fix java Pull requests that update Java code labels Feb 15, 2024
@lifeofguenter lifeofguenter merged commit 659ab70 into jenkinsci:master Feb 15, 2024
16 checks passed
andrey-fomin added a commit to andrey-fomin/bitbucket-branch-source-plugin that referenced this pull request Mar 10, 2024
Previously token was fetched only once and saved in BitbucketSCMSource.

Fixes jenkinsci#808.
See also jenkinsci#810 and jenkinsci#796.
lifeofguenter pushed a commit that referenced this pull request Mar 10, 2024
Previously token was fetched only once and saved in BitbucketSCMSource.

Fixes #808.
See also #810 and #796.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication fails when using OAuth Credentials
3 participants