Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-32372] Inject the payload into the build #26

Merged
merged 2 commits into from Jan 20, 2016

Conversation

fbelzunc
Copy link
Contributor

@fbelzunc fbelzunc commented Jan 9, 2016

This pull request injects the payload received by BitBucket into the build through $BITBUCKET_PAYLOAD, which will allow users to process the payload on the build through the environment variable.

@reviewbybees

@ghost
Copy link

ghost commented Jan 9, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@@ -40,7 +41,7 @@ public BitBucketTrigger() {
/**
* Called when a POST is made.
*/
public void onPost(String triggeredByUser) {
public void onPost(String triggeredByUser, final String payload) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary compatibility break

@oleg-nenashev
Copy link
Member

🐛 for the binary compatibility issue.
I'm also aware about Workflow compatibility

@fbelzunc
Copy link
Contributor Author

@oleg-nenashev @amuniz Can I have your bee now?

@amuniz
Copy link
Member

amuniz commented Jan 12, 2016

🐝

@fbelzunc
Copy link
Contributor Author

@reviewbybees done

@ghost
Copy link

ghost commented Jan 18, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

fbelzunc added a commit that referenced this pull request Jan 20, 2016
[FIXED JENKINS-32372] Inject the payload into the build
@fbelzunc fbelzunc merged commit ca70985 into jenkinsci:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants