Bug/jenkins 40662 run details close problem #93
Conversation
…es, to avoid brittle use of pause
…etails in the URL form of :org/:pipeline/:branch/:runId and the modal doesn't close properly
…e the modal is closed as this will ensure downstream actions occur after the navigation is completed
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| const blueActivityPage = browser.page.bluePipelineActivity().forJob(jobName, 'jenkins'); | ||
| blueActivityPage.waitForRunRunningVisible(jobName + '-1'); | ||
| const blueRunDetailPage = browser.page.bluePipelineRunDetail().forRun(jobName, 'jenkins', 1); | ||
| blueRunDetailPage.closeModal('/activity'); |
There was a problem hiding this comment.
@cliffmeyers you need to wait until the run is finished otherwise this can lead to flaky tests 🐛
There was a problem hiding this comment.
@scherler closing the modal while the job is running can lead to a flaky test? Can you explain why?
There was a problem hiding this comment.
Fixed in 00843f0
There was a problem hiding this comment.
@cliffmeyers no not that. You do not finished the test with waitForJobEnd (or similar) that can lead to suprises
| @@ -0,0 +1,60 @@ | |||
| /** | |||
| * @module waitForLocationChange | |||
| * @memberof custom_commands | |||
There was a problem hiding this comment.
You have to add this to the index in the comment for documentation reasons 🐜
There was a problem hiding this comment.
Fixed in 136d786
Description
Submitter checklist
Reviewer checklist
@reviewbybees