Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] Pipeline validation #20

Merged
merged 19 commits into from Jan 27, 2017
Merged

[WiP] Pipeline validation #20

merged 19 commits into from Jan 27, 2017

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Jan 25, 2017

This is a catch-all clean up in preparation for a preview release and validation. Includes pipeline restyling that Brody mocked up.

TODO:

  • hold off validations for new steps
  • add a slow debounce for validation during field editing, remove blur listener
  • check if the pipeline actually changed before running validation
  • handle sheet stacking for nested steps
  • moved nested step child editing to the step details view
  • JENKINS-41361 add a blurb about how to use the load/save
  • add a default pipeline
  • fix deleting stages
  • add empty child step placeholder for container steps

Blurb:
image

Empty child step placeholders:
image
image

@kzantow kzantow changed the title [Pipeline validation [WiP] Pipeline validation Jan 25, 2017
@michaelneale
Copy link
Member

tried this recently - looks 🐝 to me!

The validation is nice! We may need to massage the errors so it doesn't say "array shouldn't be 0" though but "a stage must have at least one step" (not sure if part of editor or validation code in declarative though? I think latter)

@kzantow
Copy link
Contributor Author

kzantow commented Jan 25, 2017

@michaelneale yes, I'm going to add special handling for that. the message is coming from PMD validation. I also still need to tweak when the validation gets run, it's a bit too much right now

@michaelneale
Copy link
Member

🐝 based on screenshots - will run it later, but worth a YOLO merge

@kzantow kzantow merged commit c341fdd into jenkinsci:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants