Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] [FIX JENKINS-41966] load and save #29

Merged
merged 4 commits into from Mar 10, 2017
Merged

[WiP] [FIX JENKINS-41966] load and save #29

merged 4 commits into from Mar 10, 2017

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Mar 6, 2017

This depends on corresponding changes in jenkinsci/blueocean-plugin#886

Here's a quick preview: https://www.youtube.com/watch?v=clnUzUvq--0

TODO:

  • dialog aspect ratio
  • title not present by default bug
  • default text to 'Updating Jenkinsfile' if nothing provided
  • provide a popup that they'll lose their work when leaving the page
  • italicize branch name on screen
  • error handling -
  • make sure the edit buttons only shows up for github
  • swap buttons with load/export if go directly to editor
  • sort extension points somehow - alphabetically? (do this last; already solved with new extension mechanism)

@michaelneale
Copy link
Member

nice!

@michaelneale
Copy link
Member

Amazing @kzantow !
I think this could go in. There are things (in tickets) found, but all minor except for:

https://issues.jenkins-ci.org/browse/JENKINS-42646
for empty repo.

Otherwise:

If this goes in, we can cut a blueocean-plugin so this could be published ready for RC-ish.

@kzantow kzantow merged commit 8f043b5 into jenkinsci:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants