Wip tests #1259

jtnord · 2017-07-18T19:46:10Z

just a PR for @vivek

vivek

Thanks for making these tests org aware and improving tests in general, specially with authz it should work now.

Changes look fine, there is commented code in one of the test, please remove that.

vivek · 2017-07-18T19:54:37Z

...test/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubOrgFolderPermissionsTest.java

+        }
+    }
+
+//    private static class DummyOrganisationAutorizationStrategy extends AuthorizationStrategy {


Please remove the commented code

vivek · 2017-07-18T19:56:11Z

...ipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineBaseTest.java

@@ -599,7 +601,7 @@ protected User login(String userId, String fullName, String email) throws IOExce

        UserDetails d = Jenkins.getInstance().getSecurityRealm().loadUserByUsername(bob.getId());

-        SecurityContextHolder.getContext().setAuthentication(new PrincipalAcegiUserToken(bob.getId(),bob.getId(),bob.getId(), d.getAuthorities(), bob.getId()));
+        SecurityContextHolder.getContext().setAuthentication(new PrincipalAcegiUserToken(bob.getId(),bob.getId(),bob.getId(), d.getAuthorities(), new PrincipalSid(bob.getId())));


Ah, so this was it. Thanks:)

nope - just pushing what I have been trying to get this to work....

vivek · 2017-07-18T19:56:39Z

pom.xml

@@ -31,7 +31,7 @@
    <jacoco.line.coverage>0.70</jacoco.line.coverage>
    <jacoco.missedclass.coverage>0.00</jacoco.missedclass.coverage>
    <hpi.dependencyResolution>runtime</hpi.dependencyResolution>
-    <jenkins-test-harness.version>2.15</jenkins-test-harness.version>
+    <jenkins-test-harness.version>2.23</jenkins-test-harness.version>


We had trouble upgrading to latest test harness. Lets see if CI is happy.

2.16 is needed for MockAuthorizationStrategy

michaelneale · 2017-07-18T22:39:08Z

@vivek often times James has noted that unit tests fail (I have seen it in the past, mostly it is a 403 error returned instead of a 200 in a unit test) - and a few others. Subsequent runs pass. Is this possibly related? A lot of these tests are failing due to 403 @vivek - which is what I see from time to time (CredentialsApiTests also fail) - is there some loading/race problem?

jtnord · 2017-07-18T23:05:57Z

the wiremock setup is completely broken. If you look at the test output The Github Folder fails

Jul 18, 2017 11:01:39 PM jenkins.scm.api.SCMSourceEvent$DispatcherImpl log
WARNING: SCMEventListener.onSCMSourceEvent(SCMSourceEvent) jenkins.branch.MultiBranchProject$SCMEventListenerImpl@67b9d6f3 propagated an exception
java.lang.NoClassDefFoundError: org/apache/commons/io/Charsets
        at jenkins.branch.MultiBranchProject$SCMEventListenerImpl.globalEventsListener(MultiBranchProject.java:1098)
        at jenkins.branch.MultiBranchProject$SCMEventListenerImpl.onSCMSourceEvent(MultiBranchProject.java:1661)
        at jenkins.scm.api.SCMSourceEvent$DispatcherImpl.fire(SCMSourceEvent.java:179)
        at jenkins.scm.api.SCMSourceEvent$DispatcherImpl.fire(SCMSourceEvent.java:162)
        at jenkins.scm.api.SCMEvent$Dispatcher.run(SCMEvent.java:481)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.io.Charsets
        at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
        ... 12 more

Fixing this issue (you are using 1.34of commons io rather than the 2.something that is required causes loads of the tests to fail as wiremock no longer sees the expected calls .

jtnord · 2017-07-18T23:07:04Z

...test/java/io/jenkins/blueocean/blueocean_github_pipeline/GithubOrgFolderPermissionsTest.java

+    public void canCreateWhenHavePermissionsOnDefaultOrg() throws Exception {
+        MockAuthorizationStrategy authz = new MockAuthorizationStrategy();
+        authz.grant(Jenkins.ADMINISTER).everywhere().to(user.getId());
+        j.jenkins.setAuthorizationStrategy(authz);


the jwt token becomes invalid.
a call to jwtToken = getJwtToken(j.jenkins, "vivek", "vivek"); seems to fix the issue.
`

jtnord · 2017-07-18T23:24:05Z

I'm not expecting a review of this - its just so I can trigger builds on the CI.
@michaelneale I may have fixed the intermittent 403/201 issue (I thought I had pushed it here but it seems not). will ping you when it lands.

jtnord · 2017-07-19T12:22:10Z

...ipeline-api-impl/src/test/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineBaseTest.java

@@ -54,12 +56,18 @@
 public abstract class PipelineBaseTest{
    private static  final Logger LOGGER = LoggerFactory.getLogger(PipelineBaseTest.class);

-    public PipelineBaseTest() {
+    @BeforeClass
+    public static void enableJWT() {


@michaelneale FYI this could have been the cause of some of the 403 vs 200 failures (although I have not verified this at all)

Improve the test coverage and demonstrate the issue with MBP and custom organizations. shouldFailOnValidation4 is the test that fails in this case.

vivek · 2017-07-19T15:54:01Z

@jtnord

the wiremock setup is completely broken. If you look at the test output The Github Folder fails
Caused by: java.lang.ClassNotFoundException: org.apache.commons.io.Charsets
...
Fixing this issue (you are using 1.34of commons io rather than the 2.something that is required causes loads of the tests to fail as wiremock no longer sees the expected calls .

Hmm, don't see such error in blueocean build log or when I build it locally. I wonder this is due to windows env? I am afraid if we are fixing issues that is specific to windows env and might make things worse otherwise.

jtnord · 2017-07-19T16:05:01Z

the wiremock setup is completely broken. If you look at the test output The Github Folder fails
Caused by: java.lang.ClassNotFoundException: org.apache.commons.io.Charsets

Fixing this issue (you are using 1.34of commons io rather than the 2.something that is required causes loads of the tests to fail as wiremock no longer sees the expected calls .

Hmm, don't see such error in blueocean build log or when I build it locally. I wonder this is due to windows env? I am afraid if we are fixing issues that is specific to windows env and might make things worse otherwise.

it is not in the build log - it is in the unit test output.
You will see it if you only run the one test with -Dtest=GithubOrgFolderTest.java

This is not windows specific - you can see the cause of the issue with mvn dependency:tree (or update to the latest parent pom where the enforcer will fail the build)

vivek · 2017-07-19T16:20:49Z

@jtnord Ah, right. its indexing where its failing. These tests do not check result of indexing that is why they went unnoticed. Thanks for the fix:)

jtnord · 2017-07-19T16:26:35Z

Ah, right. its indexing where its failing. These tests do not check result of indexing that is why they went unnoticed. Thanks for the fix:)

@vivek I have not fixed that - I did but then with the amount of wiremock failures I decided not to, and just add tests to cover the issues I am fixing :)

vivek · 2017-07-19T16:51:03Z

@jtnord no problem. I will take care of it, I have opened https://issues.jenkins-ci.org/browse/JENKINS-45662. Thanks.

jtnord · 2017-07-20T10:49:50Z

all rebased into #1252

jtnord added 2 commits July 18, 2017 13:35

[JENKINS-45482] potential unit test

625f581

WIP CHECKIN

1e1249c

vivek reviewed Jul 18, 2017

View reviewed changes

jtnord mentioned this pull request Jul 18, 2017

DO NOT REVIEW [JENKINS-45482] potential unit test #1258

Closed

7 tasks

jtnord commented Jul 18, 2017

View reviewed changes

jtnord added 2 commits July 19, 2017 00:43

Fix the tests to run/fail as expected

e2b9b86

Though shalt not set system properties in tests without restting them

8e14384

jtnord commented Jul 19, 2017

View reviewed changes

jtnord added 2 commits July 19, 2017 16:31

remove some debug logging

b4e65d7

[JENKINS-45360] unit test for duplicate MBP with custom org.

78a66f2

Improve the test coverage and demonstrate the issue with MBP and custom organizations. shouldFailOnValidation4 is the test that fails in this case.

jtnord closed this Jul 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wip tests #1259

Wip tests #1259

jtnord commented Jul 18, 2017

vivek left a comment

vivek Jul 18, 2017

vivek Jul 18, 2017

jtnord Jul 18, 2017

vivek Jul 18, 2017

jtnord Jul 18, 2017

michaelneale commented Jul 18, 2017 •

edited

jtnord commented Jul 18, 2017

jtnord Jul 18, 2017

jtnord commented Jul 18, 2017

jtnord Jul 19, 2017

vivek commented Jul 19, 2017

jtnord commented Jul 19, 2017

vivek commented Jul 19, 2017

jtnord commented Jul 19, 2017

vivek commented Jul 19, 2017

jtnord commented Jul 20, 2017

Wip tests #1259

Wip tests #1259

Conversation

jtnord commented Jul 18, 2017

vivek left a comment

Choose a reason for hiding this comment

vivek Jul 18, 2017

Choose a reason for hiding this comment

vivek Jul 18, 2017

Choose a reason for hiding this comment

jtnord Jul 18, 2017

Choose a reason for hiding this comment

vivek Jul 18, 2017

Choose a reason for hiding this comment

jtnord Jul 18, 2017

Choose a reason for hiding this comment

michaelneale commented Jul 18, 2017 • edited

jtnord commented Jul 18, 2017

jtnord Jul 18, 2017

Choose a reason for hiding this comment

jtnord commented Jul 18, 2017

jtnord Jul 19, 2017

Choose a reason for hiding this comment

vivek commented Jul 19, 2017

jtnord commented Jul 19, 2017

vivek commented Jul 19, 2017

jtnord commented Jul 19, 2017

vivek commented Jul 19, 2017

jtnord commented Jul 20, 2017

michaelneale commented Jul 18, 2017 •

edited