feature/JENKINS-46913-result-item-links * Linkify URLs in ResultItem headers #1400
Conversation
|
|
| @@ -41,6 +41,7 @@ | |||
| "url": "https://github.com/jenkinsci/jenkins-design-language.git" | |||
| }, | |||
| "dependencies": { | |||
| "linkifyjs": "2.1.4", | |||
There was a problem hiding this comment.
@sophistifunk this one? https://github.com/SoapBox/linkifyjs/blob/master/package.json so doesn't bring anything along, which is nice, right? (ie fairly small)
There was a problem hiding this comment.
Yeah there's not a lot of code in there. It has a dependency on JQ, but only for functions we're not using so we can just ignore it.
There was a problem hiding this comment.
I eyeballed the deps too and looks fine. I think as long as we verify that the bundles aren't bloating up after this change we are good. They do strange things sometimes :/
|
I can't seem to see what's actually going wrong here :-/ |
| @@ -78,6 +79,11 @@ export class ResultItem extends Component { | |||
| } | |||
| }; | |||
|
|
|||
| urlClicked = (e: Event) => { | |||
| console.log('urlClicked'); | |||
There was a problem hiding this comment.
Probably just make sure we remove that before PR merge?
There was a problem hiding this comment.
Nice catch, cheers
| @@ -41,6 +41,7 @@ | |||
| "url": "https://github.com/jenkinsci/jenkins-design-language.git" | |||
| }, | |||
| "dependencies": { | |||
| "linkifyjs": "2.1.4", | |||
There was a problem hiding this comment.
I eyeballed the deps too and looks fine. I think as long as we verify that the bundles aren't bloating up after this change we are good. They do strange things sometimes :/
|
Nice - this works great. Wire it in and should go for it. Very nice. |
|
@sophistifunk doesn't this need to be published/incorporated to take effect? |
|
@NicuPascu it's just to stop the expando from opening / closing when you click a link. It's the easiest way to do it. |
|
Actually I think in the future we should be sure to publish every package change as part of the PR so it can go through ATH. Otherwise we are just pushing that risk onto the next developer who actually needs to publish. Am quite confident this change won't be an issue, but.. famous last words :) |
Linkify URLs in ResultItem headers
Description
See JENKINS-46913.
Submitter checklist
Reviewer checklist