Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code that caused the PR tab to refresh when pressing "Show More" #1621

Merged
merged 1 commit into from Jan 18, 2018

Conversation

NicuPascu
Copy link
Collaborator

@NicuPascu NicuPascu commented Jan 16, 2018

Description

Found some obsolete code that caused the render function to "return null" once every time when getting the next items before re-rendering

See JENKINS-47460.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@NicuPascu
Copy link
Collaborator Author

Before:
pr_page_refresh_before

After:
pr_page_refresh_fixed

@NicuPascu
Copy link
Collaborator Author

Given the fact that this bug was caused by some rogue piece of code that was left over from the Redux time I do not think any test is necessary

@sophistifunk
Copy link
Collaborator

bbm

@michaelneale
Copy link
Member

LGTM

@NicuPascu NicuPascu merged commit ce258fb into master Jan 18, 2018
@NicuPascu NicuPascu deleted the bug/JENKINS-47460_pr_pagination_refreshes branch January 18, 2018 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants