JENKINS-49929 Regression: Log fails to auto update in karaoke mode #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't the foggiest idea how we would test this mechanically, only a certainly that writing a reliable ATH case for it would take 2 weeks. |
|
Prettier is not fun for changes like this, hard to see what the actual issue was, needs to be run against the whole codebase in one fell swoop and then applied during commit time as well |
kzantow
reviewed
Mar 7, 2018
| prefix: `step-${step.id}-`, | ||
| }} | ||
| />); | ||
| children = ( |
There was a problem hiding this comment.
oh thank God that spread syntax is gone
There was a problem hiding this comment.
Word. I kills it where I finds it.
kzantow
reviewed
Mar 7, 2018
| } else if (step.isInputStep) { | ||
| children = <InputStep step={step} key="step" classicInputUrl={classicInputUrl} />; | ||
| } else if (!logArray && step.hasLogs) { | ||
| children = <span key={'span'}> </span>; | ||
| } | ||
| const getLogForNode = () => { | ||
| if (this.pager.log === undefined || (this.pager.log && !this.pager.log.data)) { | ||
| const cfg = { url: step.logUrl }; | ||
| const cfg = { url: step.logUrl, followAlong: this.props.augmenter.karaoke }; |
There was a problem hiding this comment.
Yes, the other changes I fixed for readability while trying to understand the issue. Figured no reason to throw them away and have to do it again next week.
kzantow
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See JENKINS-49929.
Submitter checklist
Reviewer checklist