Latest sse-gateway plugin #1767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@kshultzCB PTAL, we need your go ahead on this. |
kzantow
approved these changes
Jul 23, 2018
|
@kshultzCB in terms of what we want more that ATH tests would be to confirm manually whether SSE events are delivered on different interactions with blueocean. Thanks. |
|
There might be some problems. It's hard to say for sure, since I'm not able to hit the update center when running from
I don't know if this is relevant to the SSE problems I'm having.
I've been working on a reliable way to recreate this, and haven't found it yet. |
|
I take back what I said about not being able to recreate it. Looks like you can hit this by going back to the terminal window in which you started Jenkins, and hitting
One of the more relevant looking bits is: I've never seen Jenkins do anything like this before, until running this PR in dev mode. |
|
@kshultzCB Thanks for looking in to it. so the exception below happens only after you hit enter, forcing jenkins to reload? |
|
@vivek - it looks that way, yes. As I mentioned earlier, I'm having problems with not being able to connect to the update center correctly. I suppose it's possible those are related? That problem can easily be recreated without restarting Jenkins. And was an issue before I ran this PR build - in other words, I hit this when I run from master as well. Might be worthwhile for someone without a wonky local environment to run through these quick steps:
That seems the fastest way to recreate. |
|
@kshultzCB pressing Enter on jenkins run using We should be able to reproduce it without it to call out genuine bug. Since these
I doubt. sse gateway and all dependencies are served from local build update center shouldn't cause CCE errors. |
|
Things look good to me from an end-user standpoint. Standard restarts via http://1.2.3.4:8080/jenkins/restart don't trigger the odd behavior I described above with I figured that certificate problem with the update center was unrelated - just was providing it as a "preexisting condition." :) It do think it would be good to understand why the |
Cool, thanks.
This feature never worked for me from the beginning, I do not use it often so never paid attention to find more about it. So to try again, I launched blueocean (from master branch) and tried pressing enter running instance and it gives strange errors. So yeah, probably there is something fixable there. Maybe @imeredith knows. |
|
Closed. Upgrade to sse-gateway 1.16 pr #1809. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test latest sue-gateway plugin. See discussion on sse-gateway PR for details.
Submitter checklist
Reviewer checklist