JENKINS-56773 - Disable Executor plugin by default, and throttle requests for the api for those that have it installed

[halkeye]

Description

See JENKINS-56773.

Submitter checklist

• Link to JIRA ticket in description, if appropriate.
• Change is code complete and matches issue description
• Appropriate unit or acceptance tests or explanation to why this change has no tests
• Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

• Run the changes and verified the change matches the issue description
• Reviewed the code
• Verified that the appropriate tests have been written or valid explanation given

[NicuPascu]

LGTM 🐝

[sophistifunk]

Can we name this FETCH_TIMEOUT_MS?

[halkeye]

done

…

On Mon, Apr 8, 2019 at 3:40 PM Josh McDonald ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In blueocean-executor-info/src/main/js/ExecutorInfoService.js <#1947 (comment)> : > + +const FETCH_TIMEOUT = 30 /* seconds */ * 1000 /* milliseconds */; Can we name this FETCH_TIMEOUT_MS? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1947 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGuBxl_WHdOoDTP0Xc4e5XVOSUwcjrfks5ve8VVgaJpZM4cjII8> .

[sophistifunk]

🐝

[sophistifunk]

LGTM

[tempora-mutantur]

Thank you. Can you, please, tell when this is going to be released?

[halkeye]

Probably tomorrow, it just got merged today, i'm cleaning up a few infra stuff to finish testing before releasing

…

On Wed, Apr 24, 2019 at 10:55 PM Aliaksei ***@***.***> wrote: Thank you. Can you, please, tell when this is going to be released? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1947 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA24BZN52UXCHCCLNS7R4TPSFBUJANCNFSM4HEMQI6A> .

[tempora-mutantur]

Hi, @halkeye . As I see, the load is still pretty high after the update.

Could you, please, tell if I can disable the blueocean-executor-info plugin because the dependency was disabled?
Thank you

[halkeye]

yea go ahead and disable it, its an optional addon

…

On Fri, May 3, 2019 at 2:56 AM Aliaksei ***@***.***> wrote: Hi, @halkeye <https://github.com/halkeye> . As I see, the load is still pretty high after the update. [image: image] <https://user-images.githubusercontent.com/19176095/57130609-aca2f100-6da2-11e9-92a8-010282961845.png> Could you, please, tell if I can disable the blueocean-executor-info plugin because the dependency was disabled? Thank you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1947 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA24B2HM4ET6F277ISQ62TPTQD3PANCNFSM4HEMQI6A> .