Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix response json data of API get SCM repositories in an organization #1955

Merged
merged 1 commit into from May 23, 2019
Merged

Fix response json data of API get SCM repositories in an organization #1955

merged 1 commit into from May 23, 2019

Conversation

soulseen
Copy link
Contributor

@soulseen soulseen commented Apr 24, 2019

Signed-off-by: soulseen sunzhu@yunify.com

Description

the api of get SCM repositories in an organization:

curl -v -u xxx:yyy http://localhost:8080/jenkins/blue/rest/organizations/jenkins/scm/github/organizations/CloudBees-community/repositories/?credentialId=github&pageSize=10&pageNumber=3

The json response in filed item missing },like this:

"items" : [ {
      "_class" : "io.jenkins.blueocean.blueocean_github_pipeline.GithubRepository",
      "_links" : {
        "self" : {
          "_class" : "io.jenkins.blueocean.rest.hal.Link",
          "href" : "/organizations/jenkins/scm/github/organizations/CloudBees-community/repositories/bees-cli-router-plugin/"
        }
      },
      "defaultBranch" : "master",
      "description" : "CloudBees SDK \"router:*\" plugin",
      "name" : "bees-cli-router-plugin",
      "permissions" : {
        "admin" : false,
        "push" : false,
        "pull" : true
      },
      ...]

and In my actual use, the response data also have private and fullName filed in item.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Signed-off-by: soulseen <sunzhu@yunify.com>
@halkeye
Copy link
Member

halkeye commented Apr 24, 2019

@soulseen can you update the PR with actual details of why you want this change? The title just says "update readme" and the description says something about not json.

@soulseen soulseen changed the title Update blueocean-rest README Fix response json data of API get SCM repositories in an organization Apr 25, 2019
@soulseen
Copy link
Contributor Author

@halkeye ok

@sophistifunk
Copy link
Collaborator

This just about fixing the example JSON response in the README, which makes sense.

LGTM

@halkeye
Copy link
Member

halkeye commented May 23, 2019

can you merge master to fix the ci.jenkins build issue?

@halkeye
Copy link
Member

halkeye commented May 23, 2019

actually its just readme, merging

@halkeye halkeye merged commit c7b3227 into jenkinsci:master May 23, 2019
halkeye added a commit that referenced this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants