[UX-431] Externalize some packages #232
Conversation
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@jenkins-cd/js-extensions", | |||
| "version": "0.0.14", | |||
| "version": "0.0.15-beta4", | |||
There was a problem hiding this comment.
Yes ... I need to do a proper (non --tag) release before merging this PR.
There was a problem hiding this comment.
I've taken a look at this PR on my windows machine and I can successfully build the dashboard now but there are several test failures.
Video(4:30 min) with my repo steps: [https://www.youtube.com/watch?v=KFe-ubQ-VdA?version=3&vq=hd1080]
Build Summary: https://gist.github.com/ianceicys/eafeba18ae28435cdaaf76dc4c7bb385
nohup test failure - https://gist.github.com/anonymous/4759fee0a0218fe9cb5aa4324a2111d1
sh test failure - https://gist.github.com/anonymous/c554be4948c2bd949de1222dc437c005
There was a problem hiding this comment.
A lot of the tests use "sh" steps in pipeline, which I don't think will work on windows. They could be changed to simply echo output - and then work across platforms (and would serve the same purpose, as long as the assertions are still there).
|
🐝 I think this looks good. |
react and react-dom need to be done manually because we need to make sure they are done together
really just trying to trigger another PR build ;)
Related to issue UX-431.
Externalizes some of the NPM packages used in the web and dashboard plugins.
I had to make a bugfix to js-builder and so also included a possible fix for JENKINS-35180
@reviewbybees