Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-47929] Extensible run details tabs #2345

Merged
merged 4 commits into from
Nov 13, 2022

Conversation

stuartrowe
Copy link
Contributor

@stuartrowe stuartrowe commented Nov 2, 2022

Description

See JENKINS-47929.
Fixing issues reported after #2268 was merged.

Unit/Acceptance Tests
Added additional test for RunDetailsArtifacts component in run-details-artifacts-spec.js.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@stuartrowe stuartrowe marked this pull request as ready for review November 2, 2022 22:44
@stuartrowe stuartrowe requested a review from a team as a code owner November 2, 2022 22:44
@stuartrowe
Copy link
Contributor Author

@olamy I've fixed the issue with my previous version of this change. The new test failures appear to be existing issues on master.

@olamy olamy changed the title Jenkins 47929 [JENKINS-47929] Extensible run details tabs Nov 13, 2022
@olamy olamy merged commit 099bbff into jenkinsci:master Nov 13, 2022
@olamy
Copy link
Member

olamy commented Nov 13, 2022

@stuartrowe Thanks!

@stuartrowe stuartrowe deleted the JENKINS-47929 branch November 13, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants