[JENKINS-70379] upgrade to run on java 11 #2379

car-roll · 2023-01-05T05:25:33Z

Description

See JENKINS-70379.

Submitter checklist

Link to JIRA ticket in description, if appropriate.
Change is code complete and matches issue description
Appropriate unit or acceptance tests or explanation to why this change has no tests
Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

Run the changes and verified the change matches the issue description
Reviewed the code
Verified that the appropriate tests have been written or valid explanation given

...t-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitReadSaveService.java

jglick · 2023-01-05T12:15:15Z

pom.xml

        when changing jenkins core version please remember to change it in Jenkinsfile as well jenkinsVersions
        and  acceptance-tests/runner/scripts/args.sh


...ne/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitBareRepoReadSaveRequest.java

...t-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitReadSaveService.java

jglick · 2023-01-05T12:18:24Z

blueocean-git-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitUtils.java

@@ -48,8 +48,8 @@
 import org.eclipse.jgit.revwalk.RevCommit;
 import org.eclipse.jgit.revwalk.RevTree;
 import org.eclipse.jgit.revwalk.RevWalk;
-import org.eclipse.jgit.transport.JschConfigSessionFactory;
-import org.eclipse.jgit.transport.OpenSshConfig;
+import org.eclipse.jgit.transport.ssh.jsch.JschConfigSessionFactory;


https://issues.jenkins.io/browse/JENKINS-70379 FTR

updated PR title

jglick · 2023-01-05T12:19:43Z

pom.xml

+        <dependency>
+            <groupId>org.jenkins-ci.modules</groupId>
+            <artifactId>instance-identity</artifactId>
+            <version>116.vf8f487400980</version>


jenkinsci/bom#1647

car-roll · 2023-01-05T18:45:34Z

Would the continuous-integration build failure stop incrementals from being built?

MarkEWaite · 2023-01-05T18:58:03Z

Would the continuous-integration build failure stop incrementals from being built?

The failure is on the outdated blue ocean specific CI server that the infra team is decommissioning. https://ci.jenkins.io/job/Plugins/job/blueocean-plugin/view/change-requests/job/PR-2379/lastSuccessfulBuild/artifact/ shows a successful build and a zip of artifacts to download. I'm going to try that zip of artifacts in my Jenkins installation as an experiment.

I don't know if Blue Ocean builds are equipped to deliver incremental.

jglick · 2023-01-05T19:19:24Z

https://repo.jenkins-ci.org/incrementals/io/jenkins/blueocean/blueocean/1.26.1-rc4327.e4f44aba58fa/ (and other artifacts) got deployed OK.

MarkEWaite

I deployed 1.26.1-rc4327.e4f44aba58fa and confirmed that the scenario described in JENKINS-70379 works with Jenkins 2.375.1.

The code changes look very good to me as well.

jglick · 2023-01-05T21:11:24Z

@olamy @dwnusbaum @batmat

shamil · 2023-01-05T21:13:23Z

any reason I see this change in the plugin manager? I assume this is not released yet, and I shouldn't see it there...

car-roll · 2023-01-05T21:26:45Z

@shamil thanks for catching that, will fix

olamy · 2023-01-06T06:06:19Z

Would the continuous-integration build failure stop incrementals from being built?

The failure is on the outdated blue ocean specific CI server that the infra team is decommissioning. https://ci.jenkins.io/job/Plugins/job/blueocean-plugin/view/change-requests/job/PR-2379/lastSuccessfulBuild/artifact/ shows a successful build and a zip of artifacts to download. I'm going to try that zip of artifacts in my Jenkins installation as an experiment.

Not exactly. Failures are happening in ATH test module which is not running per default on ci.j.io
There is a task (sorry I don't remember the id) in infradesk to be able to run those tests in ci.j.io and stop the current ci server running the ath tests which is paid by cloudbees.
But the task has never really progressed..

I don't know if Blue Ocean builds are equipped to deliver incremental.

lemeurherve · 2023-01-18T20:30:42Z

But the task has never really progressed..

Yes sorry about that, been busy on other tasks I've de-prioritized it, but didn't forget, still on my todo list.

jenkinsci#2379, and fixing `github` dep versions

* Use `SubTask.getOwnerExecutable` * Update to releases * Removing some gratuitous version overrides * Using newest available BOM * Restoring `InjectedTest`, deleting Animal Sniffer config obsolete as of #2379, and fixing `github` dep versions * May as well go to 2.401.x now

* Use `SubTask.getOwnerExecutable` * Update to releases * Removing some gratuitous version overrides * Using newest available BOM * Restoring `InjectedTest`, deleting Animal Sniffer config obsolete as of jenkinsci#2379, and fixing `github` dep versions * May as well go to 2.401.x now

car-roll commented Jan 5, 2023

View reviewed changes

...t-pipeline/src/main/java/io/jenkins/blueocean/blueocean_git_pipeline/GitReadSaveService.java Outdated Show resolved Hide resolved

car-roll marked this pull request as ready for review January 5, 2023 05:29

car-roll requested a review from a team as a code owner January 5, 2023 05:29

car-roll marked this pull request as draft January 5, 2023 05:29

car-roll force-pushed the jdk11 branch from d19855e to 4d3f572 Compare January 5, 2023 05:51

car-roll closed this Jan 5, 2023

car-roll reopened this Jan 5, 2023

car-roll force-pushed the jdk11 branch from 4d3f572 to f31b976 Compare January 5, 2023 06:21

upgrade to run on java 11

92f1227

car-roll force-pushed the jdk11 branch from f31b976 to 92f1227 Compare January 5, 2023 06:35

jglick reviewed Jan 5, 2023

View reviewed changes

address review comments

e4f44ab

car-roll changed the title ~~upgrade to run on java 11~~ [JENKINS-70379] upgrade to run on java 11 Jan 5, 2023

jglick approved these changes Jan 5, 2023

View reviewed changes

MarkEWaite approved these changes Jan 5, 2023

View reviewed changes

car-roll marked this pull request as ready for review January 5, 2023 20:05

dwnusbaum approved these changes Jan 5, 2023

View reviewed changes

car-roll added the dependencies Pull requests that update a dependency file label Jan 5, 2023

bump dot version due to accidental deploy

d6ed68f

car-roll added the developer label Jan 5, 2023

car-roll merged commit d37d813 into jenkinsci:master Jan 5, 2023

car-roll deleted the jdk11 branch January 5, 2023 21:38

car-roll mentioned this pull request Jan 5, 2023

add blueocean-1.26.1-JDK11TEST to ignore list jenkins-infra/update-center2#671

Merged

MarkEWaite mentioned this pull request Jan 6, 2023

Require Jenkins 2.361.4 and Java 11 #2380

Merged

7 tasks

This was referenced Jan 18, 2023

upgrade core version to 2.332.1 #2267

Closed

Bump parent plugin from 4.25 to 4.47 to fix flaky JwtAuthenticationServiceImplTest #2333

Closed

Migrate Blue Ocean remaining jobs from ci.blueocean.io to the OSS Infra jenkins-infra/helpdesk#2954

Open

jglick added a commit to jglick/blueocean-plugin that referenced this pull request Apr 10, 2023

Restoring InjectedTest, deleting Animal Sniffer config obsolete as of

a87bc7d

jenkinsci#2379, and fixing `github` dep versions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-70379] upgrade to run on java 11 #2379

[JENKINS-70379] upgrade to run on java 11 #2379

car-roll commented Jan 5, 2023 •

edited

jglick Jan 5, 2023

car-roll Jan 5, 2023

jglick Jan 5, 2023

car-roll Jan 5, 2023

jglick Jan 5, 2023

car-roll commented Jan 5, 2023

MarkEWaite commented Jan 5, 2023 •

edited

jglick commented Jan 5, 2023

MarkEWaite left a comment

jglick commented Jan 5, 2023

shamil commented Jan 5, 2023 •

edited

car-roll commented Jan 5, 2023

olamy commented Jan 6, 2023 •

edited

lemeurherve commented Jan 18, 2023 •

edited

		when changing jenkins core version please remember to change it in Jenkinsfile as well jenkinsVersions
		and acceptance-tests/runner/scripts/args.sh

[JENKINS-70379] upgrade to run on java 11 #2379

[JENKINS-70379] upgrade to run on java 11 #2379

Conversation

car-roll commented Jan 5, 2023 • edited

Description

Submitter checklist

Reviewer checklist

jglick Jan 5, 2023

Choose a reason for hiding this comment

car-roll Jan 5, 2023

Choose a reason for hiding this comment

jglick Jan 5, 2023

Choose a reason for hiding this comment

car-roll Jan 5, 2023

Choose a reason for hiding this comment

jglick Jan 5, 2023

Choose a reason for hiding this comment

car-roll commented Jan 5, 2023

MarkEWaite commented Jan 5, 2023 • edited

jglick commented Jan 5, 2023

MarkEWaite left a comment

Choose a reason for hiding this comment

jglick commented Jan 5, 2023

shamil commented Jan 5, 2023 • edited

car-roll commented Jan 5, 2023

olamy commented Jan 6, 2023 • edited

lemeurherve commented Jan 18, 2023 • edited

car-roll commented Jan 5, 2023 •

edited

MarkEWaite commented Jan 5, 2023 •

edited

shamil commented Jan 5, 2023 •

edited

olamy commented Jan 6, 2023 •

edited

lemeurherve commented Jan 18, 2023 •

edited