Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some failing ATH tests, increase some timeout to avoid flakyness of some tests #2495

Merged
merged 22 commits into from
Sep 16, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Sep 12, 2023

Signed-off-by: Olivier Lamy olamy@apache.org

Description

See JENKINS-XXXXX.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
…git.GitSCM.ALLOW_LOCAL_CHECKOUT=true

Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy changed the title add an option to disable flaky tests on CI Fix some failing ATH test, increase some timeout to avoid flakyness of some tests Sep 15, 2023
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy marked this pull request as ready for review September 16, 2023 09:25
@olamy olamy requested a review from a team as a code owner September 16, 2023 09:25
@olamy olamy added the chore label Sep 16, 2023
@olamy olamy changed the title Fix some failing ATH test, increase some timeout to avoid flakyness of some tests Fix some failing ATH tests, increase some timeout to avoid flakyness of some tests Sep 16, 2023
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy merged commit 76bc08e into master Sep 16, 2023
2 of 5 checks passed
@olamy olamy deleted the disable-flaky-ath-tests-on-ci branch September 16, 2023 23:15
@@ -368,6 +365,7 @@ public void shouldFindUserStoreCredential() throws Exception {
}

@Test
@Ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that #2503 may have helped, but the test was dubious to begin with. In fact CloudBees is experimenting with disabling Internet access during PCT runs, to reduce flakiness, which I think would cause this test to hang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants