Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jenkins 36974 35796 stop build #446

Closed
wants to merge 36 commits into from

Conversation

cliffmeyers
Copy link
Contributor

@cliffmeyers cliffmeyers commented Aug 29, 2016

Description

  • This PR includes changes from Task/jenkins 36687 run pipeline refactor #440 so ideally we'll merge than first, then merge master again to clean up the diff.
  • See JENKINS-35796.
  • See JENKINS-36974.
  • This PR incorporates the following changes
    • Add a "Stop" button to the Activity tab, to the right of any build that is running or queued,
    • Add a "Stop" button to Run Details for any build that is running (not sure if handling queued is in scope or feasible; conversations are in-progress)
    • Replace the "Run" button on the Activity tab for non multi-branch projects with the new implementation
    • Replace the "Run" buttons on the Branches and PR tabs with the new implementation (this wasn't called out in any ticket but seems sensible to do)
  • TODO item:
    • Find a better way to prevent duplicate toasts being fired when a job is started or stopped. This is handled now in ToastService - and while it works - it's perhaps concerning that multiple instances of Run button bound to the same pipeline are firing dup toasts, and that Favorites from the dashboard will also attempt to propagate a toast.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@jenkinsci/code-reviewers @reviewbybees

Cliff Meyers added 30 commits August 25, 2016 21:14
…L to the corresponding UI URL, to avoid encoding bugs
…s; add some assets for testing and in prep of "Run Pipeline" refactor
…iple "libraries" (e.g. JDL and CoreJS) in the src/main/webapp/assets directory
… be shared across plugins; support multiple subscriptions; still needs testing
…d to be caused by two SSE connections being made using the same clientId
…plicate listener for each subscription added
…prevents them from being added; in place until we find a more elegant fix in upstream code
…o it can toggle or show only run or stop; update Activity tab to use new RunButton at top for non multi-branch
@michaelneale
Copy link
Member

needs updating to master again...

@cliffmeyers
Copy link
Contributor Author

Gonna wait for JWT to land before I merge again.

@michaelneale
Copy link
Member

ace

@cliffmeyers
Copy link
Contributor Author

Also closing this PR; superseded by #448

@cliffmeyers cliffmeyers deleted the feature/JENKINS-36974-35796-stop-build branch September 26, 2016 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants