Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/close modal goes to activity #699

Merged
merged 3 commits into from Jan 11, 2017
Merged

Hotfix/close modal goes to activity #699

merged 3 commits into from Jan 11, 2017

Conversation

cliffmeyers
Copy link
Contributor

@cliffmeyers cliffmeyers commented Jan 11, 2017 •
edited

Description

Closing of the Run Modal was not navigating back to the previous route in many instances:

  • Coming from the dashboard, after close it was navigating to /activity instead of dashboard
  • Coming from /branches, closing was navigating to /activity
  • Deep-linking directly to Run Details /pipeline then closing was navigating back to /activity correctly
  • Deep-linking to Run Details with no tab specified then closing was navigating back to /activity correctly
  • Verified the above scenarios. Wrote a few unit tests for the buggy code in question

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@reviewbybees

Cliff Meyers added 2 commits January 10, 2017 20:36
fix a bug where closing the Run Details modal would navigate back to …
04bacde 
…/activity instead of the previous route in many cases (from Dashboard, from Branches tab)
publish beta core-js; update deps
f7c0ae1
@cliffmeyers
Copy link
Contributor Author

Pending local ATH run...

@cliffmeyers
Copy link
Contributor Author 

2017-01-10 20:53:40,791 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - OK. 1027  total assertions passed. (9m 24s)
2017-01-10 20:53:40,861 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - [20:53:40] Finished 'default' after 9.4 min
**** NightwatchRunner - No failures.

sophistifunk
sophistifunk reviewed Jan 11, 2017
View reviewed changes
blueocean-core-js/src/js/services/LocationService.js
*/
export default class LocationService {
@observable current;
@observable previous;

@action setCurrent(newLocation) {
if (newLocation.action !== 'REPLACE') {
this.current = this.previous;
this.previous = this.current;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sophistifunk
Copy link
Collaborator

🐝

@cliffmeyers
Copy link
Contributor Author

ATH passed again.

017-01-10 21:18:52,896 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - OK. 1094  total assertions passed. (10m 37s)
2017-01-10 21:18:52,961 [Thread-3] INFO   (InputStreamHandler.java:47) com.github.eirslett.maven.plugins.frontend.lib.DefaultGulpRunner - [21:18:52] Finished 'default' after 11 min
**** NightwatchRunner - No failures.

@cliffmeyers cliffmeyers merged commit 39e09e5 into master Jan 11, 2017
@cliffmeyers cliffmeyers deleted the hotfix/close-modal-goes-to-activity branch January 11, 2017 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophistifunk sophistifunk sophistifunk left review comments

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
2 participants
@cliffmeyers @sophistifunk