Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JENKINS-42520 Branch label wraps #888

Merged
merged 1 commit into from Mar 7, 2017
Merged

JENKINS-42520 Branch label wraps #888

merged 1 commit into from Mar 7, 2017

Conversation

sophistifunk
Copy link
Collaborator

  • Update stories to exercise isMultiBranch flag
  • Fix propertyTypes typo
  • Return span into .u-label-value pair for branch label

Description

See JENKINS-42520.

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@sophistifunk
bug/jenkins-42520-branch-label-wraps
db7537a 
 * Update stories to exercise isMultiBranch flag
 * Fix propertyTypes typo
 * Return span into .u-label-value pair for branch label
@michaelneale
Copy link
Member

nice one!

@michaelneale
Copy link
Member

passes ATH

@michaelneale
Copy link
Member

🐝 and looks good.

@sophistifunk sophistifunk merged commit 21dbcaf into master Mar 7, 2017
@sophistifunk sophistifunk deleted the bug/jenkins-42520-branch-label-wraps branch March 7, 2017 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug needs-review
Projects
None yet
Milestone
No milestone
2 participants
@sophistifunk @michaelneale