[FIX JENKINS-42784] Fix creation optimization and empty repo #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were passing by luck. Fixed to refer to existing repo inside jenkinsci repo.
Fixes issue where credentials attached to the org folder was not discovered by github scm source during github api calls. Makes simpleOrgTest to work only with github access token to avoid flackyness related to github api rate limit and subsequent read time outs.
|
🐝 especially if ATH is happy |
|
@cliffmeyers @vivek able to give your blessing? |
|
@vivek @cliffmeyers I would love if you could give this a look, but probably important to get it in quickly |
cliffmeyers
reviewed
Mar 22, 2017
There was a problem hiding this comment.
LGTM. Couple minor comments. Will let @vivek have final say as he's way more knowledgeable on Java side.
|
|
||
| StringBuilder sb = new StringBuilder(); | ||
| if (gitHubSCMNavigator != null) { | ||
| Matcher matcher = Pattern.compile("\\((.*?)\\\\b\\)\\?").matcher(gitHubSCMNavigator.getPattern()); |
There was a problem hiding this comment.
This might benefit from a comment - it's clear to me because I'm familiar w/ how the repo names are put in the regexp, but others might be confused by this.
| } | ||
| if (sb.length() > 0) { | ||
| gitHubSCMNavigator.setPattern(sb.toString()); | ||
| } |
There was a problem hiding this comment.
In general maybe some of this regexp handling code would benefit from method extraction but that's just a style thing, no biggie.
8 tasks
|
🐝 |
|
Already included by #919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See JENKINS-42784.
To test this, use cases where no Jenkinsfile exists, or creating from a completely empty repo.
Submitter checklist
Reviewer checklist