Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/jenkins 43702 dashboard more scroll position #982

Merged
merged 4 commits into from Apr 20, 2017

Conversation

cliffmeyers
Copy link
Contributor

@cliffmeyers cliffmeyers commented Apr 20, 2017

Description

Submitter checklist

  • Link to JIRA ticket in description, if appropriate.
  • Change is code complete and matches issue description
  • Appropriate unit or acceptance tests or explanation to why this change has no tests
  • Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.
  • Ran Acceptance Test Harness against PR changes.

Reviewer checklist

  • Run the changes and verified the change matches the issue description
  • Reviewed the code
  • Verified that the appropriate tests have been written or valid explanation given

@cliffmeyers
Copy link
Contributor Author

@i386
Copy link
Contributor

i386 commented Apr 20, 2017

🐝🙌

@i386
Copy link
Contributor

i386 commented Apr 20, 2017

Lovely thanks for writing this test.

@cliffmeyers cliffmeyers merged commit 89f2293 into master Apr 20, 2017
@cliffmeyers cliffmeyers deleted the bug/JENKINS-43702-dashboard-more-scroll-position branch April 20, 2017 20:33
@i386
Copy link
Contributor

i386 commented Apr 20, 2017

@cliffmeyers is there a similar test for the activity and branches (I believe you said we had regressed there at some point?) If not, can you create another ticket to improve the coverage for that area please?

@cliffmeyers
Copy link
Contributor Author

@i386 I had already added a comment to https://issues.jenkins-ci.org/browse/JENKINS-43083 to do just that.

@i386
Copy link
Contributor

i386 commented Apr 20, 2017

@cliffmeyers nice, thanks for being proactive :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants