Test pct using shallow clone #1613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
changed the title
olamy
force-pushed
the
pct-shallow-clone
branch
from
011955a
to
c3841f7
Compare
MarkEWaite
added
the
full-test
jglick
changed the title
9 tasks
MarkEWaite
added a commit
to MarkEWaite/git-client-plugin
that referenced
this pull request
Dec 5, 2022
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs.
MarkEWaite
added a commit
to jenkinsci/git-client-plugin
that referenced
this pull request
Dec 5, 2022
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs.
|
Git plugin 4.14.2 and git client plugin 3.13.1 pass all their tests when run from a shallow clone. The special case code for git plugin and git client plugin can be removed. |
MarkEWaite
added a commit
to jenkinsci/git-client-plugin
that referenced
this pull request
Dec 13, 2022
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs. (cherry picked from commit 5c98434)
6 tasks
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Dec 13, 2022
https://issues.jenkins.io/browse/JENKINS-70174 notes that the git client plugin automated tests failed when using a shallow clone (depth == 1) of a single branch. The issue was fixed for Jenkins 2.346.3 and newer with the release of git client plugin 3.13.1. This release is a backport of that fix. No plugin functionality was changed in this release. It changes the automated tests when run from a shallow clone (depth == 1) of a single branch. jenkinsci#1613 is the key consumer in the plugin bill of materials. jenkinsci/plugin-compat-tester#382 is the key consumer in the plugin compatibility tester.
jglick
pushed a commit
that referenced
this pull request
Dec 14, 2022
https://issues.jenkins.io/browse/JENKINS-70174 notes that the git client plugin automated tests failed when using a shallow clone (depth == 1) of a single branch. The issue was fixed for Jenkins 2.346.3 and newer with the release of git client plugin 3.13.1. This release is a backport of that fix. No plugin functionality was changed in this release. It changes the automated tests when run from a shallow clone (depth == 1) of a single branch. #1613 is the key consumer in the plugin bill of materials. jenkinsci/plugin-compat-tester#382 is the key consumer in the plugin compatibility tester.
|
closing it as jenkinsci/plugin-compat-tester#382 has been closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenkinsci/plugin-compat-tester#382