Allow tests with shallow clone of source repository #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test class uses the history of the git plugin to test various conditions in the GitRepositoryBrowser class. Accept that those cases are not tested when the tests are running from a shallow clone.
jglick
reviewed
Nov 29, 2022
There was a problem hiding this comment.
OK for a hotfix. In general if you want to have some predefined Git repository available for tests to work on, it would be better to either
- Set up the repo from scratch (assuming dates, commit hashes, etc. are irrelevant).
- Use
git bundle create …-plugin/src/test/resources/xxx.bundle masterto archive an example repo, and then have a test setup method rungit clone -b master …-plugin/src/test/resources/xxx.bundle.
| GitClient git = Git.with(TaskListener.NULL, new EnvVars()).getClient(); | ||
| headCommit = git.revParse("HEAD"); | ||
| } catch (IOException | InterruptedException e) { | ||
| headCommit = ObjectId.fromString("016407404eeda093385ba2ebe9557068b519b669"); // simple commit |
9 tasks
MarkEWaite
added a commit
to MarkEWaite/git-client-plugin
that referenced
this pull request
Dec 5, 2022
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs.
MarkEWaite
added a commit
to jenkinsci/git-client-plugin
that referenced
this pull request
Dec 5, 2022
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs.
6 tasks
MarkEWaite
added a commit
to jenkinsci/git-client-plugin
that referenced
this pull request
Dec 13, 2022
Do not attempt to use the local repository as a reference repository when the local repository is a shallow clone. A shallow clone repository has no content to offer as a reference. Fixes 64 test failures when the test repository is a shallow clone. jenkinsci/bom#1613 describes the experiment to run the plugin compatibility tests with shallow clones. jenkinsci/git-plugin#1365 implemented a similar change in the git plugin so that shallow cloned repositories will not fail the tests in that plugin. Will make a few tests in a shallow repository a little slower because they will require a full clone of the git client plugin repository rather than reusing the existing clone in the test workspace. Doubtful that the performance difference will be detectable within the general variability of CI test jobs. (cherry picked from commit 5c98434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow tests with shallow clone of source repository
One test class uses the history of the git plugin to test various conditions in the GitRepositoryBrowser class. Accept that those cases are not tested when the tests are running from a shallow clone.
Allow the plugin compatibility tests and other automated test environments to use a shallow clone of the repository for tests. The test conditions that are skipped as a result of this change are much less important than keeping test environments simple and consistent.
Checklist
Types of changes