Add 2.222.x line #214

timja · 2020-04-09T20:54:19Z

Adding 2.222.x line,

Blocked on jenkinsci/workflow-cps-global-lib-plugin#93 currently

sample-plugin/pom.xml

pom.xml

Mac bundled one is ancient, homebrew one is put in /usr/local just let the user configure their path, not hardcode which exe to use

timja · 2020-04-10T12:03:47Z

java.lang.NullPointerException
	at hudson.security.csrf.CrumbFilter$Security1774ServletRequest.getPathInfo(CrumbFilter.java:74)
	at hudson.cli.CliCrumbExclusion.process(CliCrumbExclusion.java:45)
	at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:127)
	at hudson.plugins.git.GitStatusCrumbExclusionTest.testNotifyCommit(GitStatusCrumbExclusionTest.java:48)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

I vaguely remember some fallout in the latest security fixes related to this ^^^

timja · 2020-04-10T21:18:54Z

This is the fix for the git plugin tests, it's merged but unreleased: jenkinsci/git-plugin#857

timja · 2020-04-10T21:26:21Z

jdk-tool passed locally for me so I assume a flake

EDIT: it failed on the next run, not sure what I'm missing to reproduce it

Edit 2: I can reproduce this with PLUGINS=jdk-tool TEST=hudson.tools.JDKInstallerTest ./local-test.sh but not via maven test or intellij in the jdk-tool repo

cc @oleg-nenashev I believe you're maintainer of this plugin

https://ci.jenkins.io/blue/organizations/jenkins/Tools%2Fbom/detail/PR-214/9/tests

hudson.tools.JDKInstallerTest

java.lang.NullPointerException
	at net.sourceforge.htmlunit.corejs.javascript.ScriptRuntime.hasTopCall(ScriptRuntime.java:3263)
	at net.sourceforge.htmlunit.corejs.javascript.InterpretedFunction.call(InterpretedFunction.java:102)
	at com.gargoylesoftware.htmlunit.javascript.host.dom.MutationObserver.attributeReplaced(MutationObserver.java:171)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:359)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.fireHtmlAttributeReplaced(HtmlElement.java:364)
	at com.gargoylesoftware.htmlunit.html.HtmlElement.setAttributeNS(HtmlElement.java:207)
	at com.gargoylesoftware.htmlunit.html.HtmlInput.setAttributeNS(HtmlInput.java:537)
	at com.gargoylesoftware.htmlunit.html.HtmlTextInput.setAttributeNS(HtmlTextInput.java:160)
	at com.gargoylesoftware.htmlunit.html.DomElement.setAttribute(DomElement.java:327)
	at com.gargoylesoftware.htmlunit.html.HtmlInput.setValueAttribute(HtmlInput.java:96)
	at hudson.tools.JDKInstallerTest.enterCredential(JDKInstallerTest.java:69)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:548)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)

timja · 2020-04-10T21:30:13Z

Can reproduce failure for pct-workflow-cps-global-lib-2.222.x / configRoundtrip – org.jenkinsci.plugins.workflow.libs.GlobalLibrariesTest

cc @dwnusbaum
https://ci.jenkins.io/blue/organizations/jenkins/Tools%2Fbom/detail/PR-214/5/tests

403 Forbidden for http://localhost:35173/jenkins/configure
Stacktrace
com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 403 Forbidden for http://localhost:35173/jenkins/configure
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:590)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:408)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:315)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:463)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:448)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.goTo(JenkinsRule.java:2506)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.goTo(JenkinsRule.java:2486)
	at org.jenkinsci.plugins.workflow.libs.GlobalLibrariesTest.configRoundtrip(GlobalLibrariesTest.java:74)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:598)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)

timja · 2020-04-12T10:21:29Z

@jglick / @oleg-nenashev

After lots of banging my head against the wall for the jdk-tool plugin test issue,

I've found where the issue lies at least,

I added some

Debug code

    Class theClass = Version.class;

    String classPath = theClass.getResource(theClass.getSimpleName() + ".class").toString();
    System.out.println("Class: " + classPath);

    String libPath = classPath.substring(0, classPath.lastIndexOf("!"));
    System.out.println("Lib:   " + libPath);

    String filePath = libPath + "!/META-INF/MANIFEST.MF";
    System.out.println("File:  " + filePath);

    Manifest manifest = new Manifest(new URL(filePath).openStream());
    Attributes attr = manifest.getMainAttributes();
    System.out.println("Manifest-Version: " + attr.getValue("Manifest-Version"));

Which when run in megawar mode in the bom repo with

mvn --show-version --batch-mode -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn --define=failIfNoTests=false --define=jth.jenkins-war.path=/Users/timja/projects/jenkinsci/bom/target/local-test/megawar.war --define=org.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn --define=forkCount=1 hpi:resolve-test-dependencies hpi:test-hpl test -Djenkins.version=2.222.1 -Denforcer.skip=true -Dtest=hudson.tools.JDKInstallerTest

Prints html unit version 2.18-1:

Class: jar:file:/Users/timja/.m2/repository/org/jenkins-ci/main/jenkins-test-harness-htmlunit/2.18-1/jenkins-test-harness-htmlunit-2.18-1.jar!/com/gargoylesoftware/htmlunit/Version.class
Lib:   jar:file:/Users/timja/.m2/repository/org/jenkins-ci/main/jenkins-test-harness-htmlunit/2.18-1/jenkins-test-harness-htmlunit-2.18-1.jar
File:  jar:file:/Users/timja/.m2/repository/org/jenkins-ci/main/jenkins-test-harness-htmlunit/2.18-1/jenkins-test-harness-htmlunit-2.18-1.jar!/META-INF/MANIFEST.MF

When run in intellij, version 2.36.0-1:

Class: jar:file:/Users/timja/.m2/repository/org/jenkins-ci/main/jenkins-test-harness-htmlunit/2.36.0-1/jenkins-test-harness-htmlunit-2.36.0-1.jar!/com/gargoylesoftware/htmlunit/Version.class
Lib:   jar:file:/Users/timja/.m2/repository/org/jenkins-ci/main/jenkins-test-harness-htmlunit/2.36.0-1/jenkins-test-harness-htmlunit-2.36.0-1.jar
File:  jar:file:/Users/timja/.m2/repository/org/jenkins-ci/main/jenkins-test-harness-htmlunit/2.36.0-1/jenkins-test-harness-htmlunit-2.36.0-1.jar!/META-INF/MANIFEST.MF
Manifest-Version: 1.0

Any idea why the bom is picking up such an ancient version of htmlunit?

for reference it appears to be caused by a combination of jenkinsci/jenkins#3991 and https://sourceforge.net/p/htmlunit/bugs/1811/

oleg-nenashev · 2020-04-12T10:32:08Z

IURC there was some code in PCT which was setting a plugin POM version for Java 11 tests, maybe there is an issue in its logic which forces old plugin pom

timja · 2020-04-12T10:35:25Z

IURC there was some code in PCT which was setting a plugin POM version for Java 11 tests, maybe there is an issue in its logic which forces old plugin pom

I think it might actually be as simple as an old parent pom in jdk-tool

but when I bump it running through PCT (megawar) I get:

[ERROR] hudson.tools.JDKInstallerTest.enterCredential  Time elapsed: 2.805 s  <<< ERROR!
java.lang.NoSuchMethodError: com.gargoylesoftware.htmlunit.html.HtmlInput.setValueAttribute(Ljava/lang/String;)Lcom/gargoylesoftware/htmlunit/Page;
	at hudson.tools.JDKInstallerTest.enterCredential(JDKInstallerTest.java:98)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:597)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)

Although it's fine in intellij and maven outside PCT

timja · 2020-04-12T10:41:12Z

🤦 turned out to be a simple fix: jenkinsci/jdk-tool-plugin#12

Missed it as I was updating the parent pom locally because of enforcer errors, but PCT just ignores enforcer

failFast

timja · 2020-04-12T11:48:06Z

Previous build was green, requires jenkins-infra/repository-permissions-updater#1488 before releasing

jglick · 2020-04-13T22:59:34Z

bom-2.190.x/pom.xml

    <packaging>pom</packaging>
    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>${project.groupId}</groupId>
-                <artifactId>bom-2.164.x</artifactId>
+                <artifactId>bom-2.204.x</artifactId>
                <version>${project.version}</version>
                <scope>import</scope>
                <type>pom</type>


ansicolor 0.6.2 is still here, below. Should this not now be deleted?

0.6.3 requires 2.164.x; i.e. now all of our lines. So we can delete the below override.

(trying this in the appropriately named #222)

jglick · 2020-04-13T23:00:11Z

pct.sh

@@ -53,6 +53,15 @@ then
    rm -fv pct-work/trilead-api/target/surefire-reports/TEST-InjectedTest.xml
 fi

+# TODO pending https://github.com/jenkinsci/jdk-tool-plugin/pull/12


jenkinsci/jdk-tool-plugin#12

jglick · 2020-04-13T23:00:20Z

pct.sh

+# TODO pending https://github.com/jenkinsci/jdk-tool-plugin/pull/12
+rm -rf pct-work/jdk-tool/target/surefire-reports/TEST-hudson.tools.JDKInstallerTest.xml
+
+# TODO pending https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/96


jenkinsci/workflow-cps-global-lib-plugin#96

jglick · 2020-04-13T23:00:29Z

pct.sh

+# TODO pending https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/96
+rm -rf pct-work/workflow-cps-global-lib/target/surefire-reports/TEST-org.jenkinsci.plugins.workflow.libs.GlobalLibrariesTest.xml
+
+# TODO Merged, but needs a release: https://github.com/jenkinsci/git-plugin/pull/857


jenkinsci/git-plugin#857

jglick · 2020-04-13T23:01:02Z

pct.sh

+# TODO pending https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/96
+rm -rf pct-work/workflow-cps-global-lib/target/surefire-reports/TEST-org.jenkinsci.plugins.workflow.libs.GlobalLibrariesTest.xml
+
+# TODO Merged, but needs a release: https://github.com/jenkinsci/git-plugin/pull/857


Suggested change

# TODO Merged, but needs a release: https://github.com/jenkinsci/git-plugin/pull/857

# TODO pending https://github.com/jenkinsci/git-plugin/pull/857

(a lot of these are merged but pending release)

jglick · 2020-04-13T23:03:18Z

sample-plugin/pom.xml

+                 also any of https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/95, https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/94,
+                 https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/93 would solve it.


Suggested change

also any of https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/95, https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/94,

https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/93 would solve it.

also pending https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/94

jenkinsci/workflow-cps-global-lib-plugin#94

Add 2.222.x line

652df50

jglick mentioned this pull request Apr 9, 2020

Bump git from 4.1.0 to 4.2.2 #207

Merged

jglick reviewed Apr 9, 2020

View reviewed changes

sample-plugin/pom.xml Show resolved Hide resolved

pom.xml Show resolved Hide resolved

timja added 5 commits April 10, 2020 09:39

Bump jcasc

7802cb2

Merge branch 'master' into 2.222.x

ba9d6f2

Add 2.204

1a73beb

Fix location for exclusion

85279ee

Use configured bash not default

81b9832

Mac bundled one is ancient, homebrew one is put in /usr/local just let the user configure their path, not hardcode which exe to use

timja mentioned this pull request Apr 10, 2020

Set minimum jenkins version to 2.164.3 jenkinsci/snakeyaml-api-plugin#1

Merged

timja added 2 commits April 10, 2020 11:02

Fixup lines

d251134

No fast failing

6188659

Disable failing git plugin test

522af6f

Fix typo

f550a6e

timja mentioned this pull request Apr 11, 2020

Adjust GlobalLibraries#configRoundTrip test for latest LTS jenkinsci/workflow-cps-global-lib-plugin#96

Merged

timja added 2 commits April 11, 2020 11:56

Ignore workflow-cps-global-lib test

7c0ebf0

Fix typo

2471aa4

timja mentioned this pull request Apr 12, 2020

Bump parent pom - fix PCT issue in bom jenkinsci/jdk-tool-plugin#12

Merged

Skip jdk-tool plugin now fix is up

2488276

timja mentioned this pull request Apr 12, 2020

Add new bom line jenkins-infra/repository-permissions-updater#1488

Merged

14 tasks

timja requested a review from jglick April 12, 2020 10:44

timja commented Apr 12, 2020

View reviewed changes

failFast Outdated Show resolved Hide resolved

timja marked this pull request as ready for review April 12, 2020 11:00

Update failFast

618b8cf

oleg-nenashev mentioned this pull request Apr 13, 2020

Update the plugin BOM to the latest version of 2.222.x jenkinsci/jenkinsfile-runner#271

Merged

timja mentioned this pull request Apr 13, 2020

Use new parent pom version jenkinsci/timestamper-plugin#60

Merged

jglick reviewed Apr 13, 2020

View reviewed changes

jglick mentioned this pull request Apr 13, 2020

Add 2.222.x & 2.204.x, remove 2.150.x #222

Merged

jglick merged commit 4def3fb into jenkinsci:master Apr 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 2.222.x line #214

Add 2.222.x line #214

timja commented Apr 9, 2020

timja commented Apr 10, 2020

timja commented Apr 10, 2020

timja commented Apr 10, 2020 •

edited

timja commented Apr 10, 2020 •

edited

timja commented Apr 12, 2020 •

edited

oleg-nenashev commented Apr 12, 2020

timja commented Apr 12, 2020 •

edited

timja commented Apr 12, 2020

timja commented Apr 12, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

jglick Apr 13, 2020

	# TODO Merged, but needs a release: https://github.com/jenkinsci/git-plugin/pull/857
	# TODO pending https://github.com/jenkinsci/git-plugin/pull/857

		also any of https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/95, https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/94,
		https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/93 would solve it.

	also any of https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/95, https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/94,
	https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/93 would solve it.
	also pending https://github.com/jenkinsci/workflow-cps-global-lib-plugin/pull/94

Add 2.222.x line #214

Add 2.222.x line #214

Conversation

timja commented Apr 9, 2020

timja commented Apr 10, 2020

timja commented Apr 10, 2020

timja commented Apr 10, 2020 • edited

timja commented Apr 10, 2020 • edited

timja commented Apr 12, 2020 • edited

oleg-nenashev commented Apr 12, 2020

timja commented Apr 12, 2020 • edited

timja commented Apr 12, 2020

timja commented Apr 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timja commented Apr 10, 2020 •

edited

timja commented Apr 10, 2020 •

edited

timja commented Apr 12, 2020 •

edited

timja commented Apr 12, 2020 •

edited