Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the plugin BOM to the latest version of 2.222.x #271

Merged
merged 4 commits into from May 6, 2020
Merged

Update the plugin BOM to the latest version of 2.222.x #271

merged 4 commits into from May 6, 2020

Conversation

oleg-nenashev
Copy link
Member

Thanks to @jglick and @timja , there is now a BOM for the 2.190.x baseline: https://github.com/jenkinsci/bom/releases/tag/bom-7 . It is still behind the JFR's target, but it is still good update.

P.S: jenkinsci/bom#214 for the 2.222.x one

@oleg-nenashev oleg-nenashev added the dependencies Pull requests that update a dependency file label Apr 13, 2020
@oleg-nenashev oleg-nenashev requested a review from a team as a code owner April 13, 2020 08:46
@oleg-nenashev
Copy link
Member Author

oleg-nenashev commented Apr 13, 2020 •
edited

Oops, it is barely related to this PR though

[2020-04-13T08:47:07.648Z] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (display-info) @ payload ---

[2020-04-13T08:47:07.648Z] [INFO] Adding ignore: module-info

[2020-04-13T08:47:08.462Z] [WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:

[2020-04-13T08:47:08.462Z] Failed while enforcing RequireUpperBoundDeps. The error(s) are [

[2020-04-13T08:47:08.462Z] Require upper bound dependencies error for org.jenkins-ci:version-number:1.6 paths to dependency are:

[2020-04-13T08:47:08.462Z] +-io.jenkins.jenkinsfile-runner:payload:1.0-beta-12-SNAPSHOT

[2020-04-13T08:47:08.462Z]   +-io.jenkins.jenkinsfile-runner:payload-dependencies:1.0-beta-12-SNAPSHOT

[2020-04-13T08:47:08.462Z]     +-org.jenkins-ci.main:jenkins-core:2.222.1

[2020-04-13T08:47:08.462Z]       +-org.jenkins-ci:version-number:1.6

[2020-04-13T08:47:08.462Z] and

[2020-04-13T08:47:08.462Z] +-io.jenkins.jenkinsfile-runner:payload:1.0-beta-12-SNAPSHOT

[2020-04-13T08:47:08.462Z]   +-io.jenkins.jenkinsfile-runner:setup:1.0-beta-12-SNAPSHOT

[2020-04-13T08:47:08.462Z]     +-io.jenkins.jenkinsfile-runner:bootstrap:1.0-beta-12-SNAPSHOT

[2020-04-13T08:47:08.462Z]       +-org.jenkins-ci:version-number:1.7

@oleg-nenashev oleg-nenashev mentioned this pull request Apr 13, 2020
Merged
timja
timja reviewed Apr 13, 2020
View reviewed changes
bootstrap/pom.xml Outdated Show resolved Hide resolved
@oleg-nenashev
Copy link
Member Author

Integration tests now explode with a weird error. Most likely it happens due to the collision between the BOM and versions defined in the integration test. I should switch all (or almost all) integration tests to use the vanilla image instead of CWP....

[2020-04-13T14:42:04.281Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-04-13T14:42:05.100Z] 2020-04-13 14:42:04.848+0000 [id=25]	SEVERE	jenkins.InitReactorRunner$1#onTaskFailed: Failed Inspecting plugin /usr/share/jenkins/ref/plugins/script-security.hpi
[2020-04-13T14:42:05.100Z] src '/usr/share/jenkins/ref/plugins/script-security.hpi' doesn't exist.
[2020-04-13T14:42:05.100Z] 	at org.apache.tools.ant.taskdefs.Expand.execute(Expand.java:148)
[2020-04-13T14:42:05.100Z] 	at hudson.ClassicPluginStrategy.unzipExceptClasses(ClassicPluginStrategy.java:556)
[2020-04-13T14:42:05.100Z] 	at hudson.ClassicPluginStrategy.explode(ClassicPluginStrategy.java:481)
[2020-04-13T14:42:05.100Z] Caused: java.io.IOException: Failed to expand /usr/share/jenkins/ref/plugins/script-security.hpi
[2020-04-13T14:42:05.100Z] 	at hudson.ClassicPluginStrategy.explode(ClassicPluginStrategy.java:484)
[2020-04-13T14:42:05.100Z] 	at hudson.ClassicPluginStrategy.createPluginWrapper(ClassicPluginStrategy.java:175)
[2020-04-13T14:42:05.100Z] 	at hudson.PluginManager$1$3$1.run(PluginManager.java:433)
[2020-04-13T14:42:05.100Z] 	at org.jvnet.hudson.reactor.TaskGraphBuilder$TaskImpl.run(TaskGraphBuilder.java:169)
[2020-04-13T14:42:05.100Z] 	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:296)
[2020-04-13T14:42:05.100Z] 	at jenkins.model.Jenkins$5.runTask(Jenkins.java:1133)
[2020-04-13T14:42:05.100Z] 	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:214)
[2020-04-13T14:42:05.100Z] 	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
[2020-04-13T14:42:05.100Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
[2020-04-13T14:42:05.100Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-04-13T14:42:05.100Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-04-13T14:42:05.100Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-04-13T14:42:11.557Z] 2020-04-13 14:42:10.438+0000 [id=24]	WARNING	h.ExtensionFinder$GuiceFinder$FaultTolerantScope$1#error: Failed to instantiate Key[type=org.jenkinsci.plugins.workflow.cps.SandboxContinuable$ScriptApprovalNote$DescriptorImpl, annotation=[none]]; skipping this component
[2020-04-13T14:42:11.557Z] java.lang.IllegalAccessError: tried to access class org.jenkinsci.plugins.workflow.cps.SandboxContinuable$ScriptApprovalNote from class org.jenkinsci.plugins.workflow.cps.SandboxContinuable$ScriptApprovalNote$DescriptorImpl

Also there is a new Jetty error log which is likely a bug after the Jetty update in JFR's master branch

2020-04-13T14:42:02.403Z] test_cwp_with_timeout
[2020-04-13T14:42:02.403Z] 2020-04-13 14:42:02.098+0000 [id=1]	WARNING	o.e.jetty.webapp.WebAppContext#doStart: Failed startup of context o.e.j.w.WebAppContext@1033576a{Jenkins v2.222.1,/jenkins,file:///app/jenkins/,UNAVAILABLE}{/app/jenkins}
[2020-04-13T14:42:02.403Z] java.lang.IllegalStateException: No config path set
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.security.PropertyUserStore.loadUsers(PropertyUserStore.java:237)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.security.PropertyUserStore.doStart(PropertyUserStore.java:308)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.addBean(ContainerLifeCycle.java:384)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.addBean(ContainerLifeCycle.java:313)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.updateBean(ContainerLifeCycle.java:864)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.security.HashLoginService.setUserStore(HashLoginService.java:126)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.security.HashLoginService.doStart(HashLoginService.java:176)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.security.SecurityHandler.doStart(SecurityHandler.java:405)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.security.ConstraintSecurityHandler.doStart(ConstraintSecurityHandler.java:419)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.ScopedHandler.doStart(ScopedHandler.java:120)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.session.SessionHandler.doStart(SessionHandler.java:504)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.ScopedHandler.doStart(ScopedHandler.java:120)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:883)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:356)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1445)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1409)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:825)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:275)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.Server.start(Server.java:407)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.server.Server.doStart(Server.java:371)
[2020-04-13T14:42:02.403Z] 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.JenkinsLauncher.createWebServer(JenkinsLauncher.java:56)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.JenkinsEmbedder.newHudson(JenkinsEmbedder.java:317)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.JenkinsEmbedder.before(JenkinsEmbedder.java:188)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.JenkinsLauncher.before(JenkinsLauncher.java:105)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.JenkinsLauncher.launch(JenkinsLauncher.java:69)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.App.run(App.java:13)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.bootstrap.Bootstrap.run(Bootstrap.java:307)
[2020-04-13T14:42:02.403Z] 	at io.jenkins.jenkinsfile.runner.bootstrap.Bootstrap.main(Bootstrap.java:127)

@oleg-nenashev oleg-nenashev changed the title Update the plugin BOM to the latest version of 2.190.x Update the plugin BOM to the latest version of 2.222.x May 5, 2020
@oleg-nenashev
Copy link
Member Author

No new issues reported by CI. I will go ahead and merge it. One test is still broken, work in progress

@oleg-nenashev oleg-nenashev merged commit d4fa36c into master May 6, 2020
@oleg-nenashev oleg-nenashev deleted the bom-2.190 branch May 6, 2020 07:20
@oleg-nenashev oleg-nenashev mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oleg-nenashev @jglick @timja