Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-58177 - replace leading hyphen in mnemonic of ws path #161

Merged
merged 2 commits into from
Jun 28, 2019

Conversation

rompic
Copy link
Contributor

@rompic rompic commented Jun 26, 2019

JENKINS-58177

This is pull requests replaces a leading hyphen in shortened workspace paths which lead to various problems in linux bash.

i also had to change another tests which is affected by this.

@jglick jglick requested a review from dwnusbaum June 26, 2019 13:52
Copy link
Contributor

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of changing existing test inputs unless it is meaningful. The change to the input obscures an example behavior you're adding.

Apply suggestions from code review

Co-Authored-By: Liam Newman <bitwiseman@gmail.com>
@bitwiseman bitwiseman merged commit 13788e5 into jenkinsci:master Jun 28, 2019
@rompic rompic deleted the JENKINS-58177 branch July 2, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants