Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the releases again to maven repo as well #2

Closed
TuomasKiviaho opened this issue Nov 1, 2013 · 8 comments
Closed

Getting the releases again to maven repo as well #2

TuomasKiviaho opened this issue Nov 1, 2013 · 8 comments

Comments

@TuomasKiviaho
Copy link
Contributor

I wondered where why the new versions were not showing and discovered that they go to jenkins repo from 1.4 forward.

7f66040

I propose that the artifacts are either to be duplicated or deployment repo changed back to the original.

I'm trying to propose an API change to a non-jenkins related project (querydsl) and this tool seemed to provide a nifty solution. It would seem a bit cumbersome when actions taken to preserve backwards compatibility suddenly introduce a non backwards compatible repository requirement. I try to avoid hardcoding the repo to the pom.xml because that's considered a bad practise, but currently that the only solution I've got if the older 1.4 version fails me.

Tuomas

@irobertson
Copy link
Contributor

Alternatively, would it be possible to work with the maven central maintainers to have http://repo.jenkins-ci.org/releases/ mirrored to central?

@kohsuke
Copy link
Member

kohsuke commented Nov 1, 2013

I deployed it to Jenkins repo just because it was easier. Let me get the group ID registered with central so that I can push there.

@kohsuke
Copy link
Member

kohsuke commented Nov 1, 2013

I filed it under https://issues.sonatype.org/browse/OSSRH-7697

@kohsuke
Copy link
Member

kohsuke commented Nov 4, 2013

1.11 is now in central

@kohsuke kohsuke closed this as completed Nov 4, 2013
@TuomasKiviaho
Copy link
Contributor Author

Thanks a bunch (for the lightning fast response as well),

org.jenkins-ci:annotation-indexer🫙1.4 seems to be missing from central. I got this working by excluding it and reverting back to the older org.jvnet.hudson version.

PS. It seems that annotation-indexer is also leaving traces of itself in form of META-INF/annotations markers. It might be wise to remove these automatically since they are not needed at runtime

@jglick
Copy link
Member

jglick commented Nov 6, 2013

org.jenkins-ci:annotation-indexer:jar:1.4 seems to be missing from central

Yeah this just gets published to the Jenkins repo currently.

(BTW I just published 1.6 today.)

annotation-indexer is also leaving traces of itself in form of META-INF/annotations markers

Yes, that is the whole point of the library. Otherwise they would be unindexed annotations.

they are not needed at runtime

They are needed at runtime. See Index.list.

@irobertson
Copy link
Contributor

Wait - they are needed at the runtime of the maven plugin, but they aren't
need at the runtime of the resulting jar, right?

On Wed, Nov 6, 2013 at 1:16 PM, Jesse Glick notifications@github.comwrote:

org.jenkins-ci:annotation-indexer:jar:1.4 seems to be missing from central

Yeah this just gets published to the Jenkins repo currently.

(BTW I just published 1.6 today.)

annotation-indexer is also leaving traces of itself in form of
META-INF/annotations markers

Yes, that is the whole point of the library. Otherwise they would be
unindexed annotations.

they are not needed at runtime

They are needed at runtime. See Index.list.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-27909584
.

@jglick
Copy link
Member

jglick commented Nov 6, 2013

No, they are needed when the application runs. That is the only way it can find the elements containing the indexable annotations. (Well it could fall back to a complete bytecode scan of the classpath, as e.g. Sisu-Guice does, but this is quite inefficient.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants