Support for autoboxing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preliminary support for autoboxing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a weird NPE from type.getInternalName() while using primitives so my initial reaction was to raise the version to 4.2 which of course did not fix the issue. Further digging around revealed that autoboxing requires bytecode level support and that GeneratorAdapter will be a way around the bug(?)
There is a GeneratorAdapter (at least in 4.2 version) that has unbox/box methods for autoboxing implementation. I replaced couple of lines at SyntheticMethod to get the new tests working and my own use case resolved but I assume that a more robust solution would be needed.