Corrected JSON structure of RabbitMQ message #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The found indications was only a single indication, it is now a list. Also, the ID of the failure cause was the key of each failure cause, it has been moved inside the failure cause structure.
rsandell
reviewed
Mar 6, 2017
| for (FoundIndication ind : foundFailureCause.getIndications()) { | ||
| foundIndicationsJSON.put("pattern", ind.getPattern()); | ||
| foundIndicationsJSON.put("matchingString", ind.getMatchingString()); | ||
| JSONObject foundIndicationJSON = new JSONObject(); |
There was a problem hiding this comment.
nit With just the difference of an s in the variable name it makes it a bit hard to read.
There was a problem hiding this comment.
And the use of JSON in the name feels very redundant.
There was a problem hiding this comment.
I can agree on the naming, I'll add a new commit.
There was a problem hiding this comment.
@rsandell I feel like having JSON in the name makes it a little more easy to read since I am dealing with actual foundFailureCauses as well as json objects containing information from failurecauses/indications. I'll keep the "JSON" but make it more clear which ones are arrays and which ones are not.
The names of variables representing various parts of the JSON structure weren't really clear. I have chosen better names for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The found indications was only a single indication,
it is now a list.
Also, the ID of the failure cause was the key of each
failure cause, it has been moved inside the failure cause
structure.