Choose status which abort the flow build. #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| @@ -201,7 +202,8 @@ public class FlowDelegate { | |||
| * Check flow status and stop if unexpected failure is detected | |||
| */ | |||
| private void statusCheck() { | |||
| if (flowRun.state.result.isWorseThan(SUCCESS)) { | |||
| if (flowRun.state.result.isWorseThan(Result.fromString(flowRun.getAbortWhenWorseThan()))) { | |||
| println("Abort execution, because on of the last builds is worse than " + flowRun.getAbortWhenWorseThan()) | |||
|
awesome that there are tests! 👍 please rebase and make sure that the feature is opt-in only. thanks a lot. |
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt" xmlns:p="/lib/hudson/project"> | ||
| <div> | ||
| <div> | ||
| Abort the build, when one single step in the build process is worster than your value. |
|
once you are done with your changes, I would also appreciate if you could squash relevant changes together. thank you! |
ueberhammDesign
force-pushed
the
master
branch
5 times, most recently
from
9a5e3ed
to
c5ac20a
Compare
|
All changes squashed together. |
| @@ -26,7 +26,7 @@ | |||
| package com.cloudbees.plugins.flow | |||
|
|
|||
| import hudson.AbortException | |||
| import hudson.console.HyperlinkNote | |||
| import hudson.console.ModelHyperlinkNote | |||
There was a problem hiding this comment.
this doesn't look right. did you squash commits that were already merged?
ueberhammDesign
force-pushed
the
master
branch
5 times, most recently
from
586079e
to
ff24c81
Compare
ueberhammDesign
added a commit
to ueberhammDesign/build-flow-plugin
that referenced
this pull request
Sep 21, 2015
ueberhammDesign
force-pushed
the
master
branch
from
eb38dd5
to
e2b25ed
Compare
ueberhammDesign
added a commit
to ueberhammDesign/build-flow-plugin
that referenced
this pull request
Sep 21, 2015
ueberhammDesign
force-pushed
the
master
branch
from
e2b25ed
to
43e0816
Compare
ueberhammDesign
force-pushed
the
master
branch
from
5cdfd2b
to
1b0fd48
Compare
ueberhammDesign
added a commit
to ueberhammDesign/build-flow-plugin
that referenced
this pull request
Sep 21, 2015
ueberhammDesign
force-pushed
the
master
branch
from
8644e99
to
f57181a
Compare
ueberhammDesign
added a commit
to ueberhammDesign/build-flow-plugin
that referenced
this pull request
Sep 21, 2015
ueberhammDesign
added a commit
to ueberhammDesign/build-flow-plugin
that referenced
this pull request
Sep 21, 2015
ueberhammDesign
force-pushed
the
master
branch
2 times, most recently
from
6197460
to
68f0c88
Compare
ueberhammDesign
added a commit
to ueberhammDesign/build-flow-plugin
that referenced
this pull request
Sep 21, 2015
ueberhammDesign
force-pushed
the
master
branch
from
7c9f03b
to
355ee04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can choose the status (Success, Unstable or Failure), which abort the flow build. It also contains, that the build can not be 'better' than any build inside the flow build.