Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow separate font configuration for description, culprits, etc. #172

Closed
wants to merge 0 commits into from

Conversation

erikhakansson
Copy link
Contributor

On our screen, job names are large and clear but Possible Culprits are hard to see from a distance.
Simply increasing font size makes the Title too large.

jan-molak added a commit that referenced this pull request Dec 28, 2015
…ter than it used to:

- The base size of the font is configured automatically based on the number of dashboard rows displayed (closes #165 and quite possibly #172)
- The user can still tweak the size of the font to make it up to 3x smaller or 2x larger
- If the number of widgets displayed becomes greater than what can comfortably fit on the screen, the dashboard becomes scrollable (closes #124 and closes #57)
@jan-molak
Copy link
Member

Hey @erikhakansson and many thanks for your pull request!

I've just made a number of improvements to the UI in order to support #165 and #124 (and potentially also resolve the problem you mention).

Could you please have a look at the latest build and let me know it the updated UI works better for you?

It is possible that even though the font size is now automatically adjusted, the proportions between the title and build details might require further work to fit your use case so I'm looking forward to hearing your thoughts!

Best,
Jan

@erikhakansson
Copy link
Contributor Author

I tried it out now, and unfortunately, the fonts are still too small for descriptions.

If I zoom in the font, the job names are too large.

@jan-molak
Copy link
Member

Gotcha, thanks for checking

@erikhakansson
Copy link
Contributor Author

Actually, I realized I didn't check with the latest build. Tried the latest release now, and it's actually better. It's still not perfect, and individual settings for headers and subtext would be optimal, but it's better than before.

Currently, our wall monitors have no network access, so we're not using build monitor plugin at all right now, but as soon as they're fixed it would be nice to have. I can try to find time to update the PR to work with the new UI, but I'm a bit cramped right now. :)

@erikhakansson
Copy link
Contributor Author

@jan-molak
I updated the PR now so that it merges. Can you have a look and see what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants