-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Ability to hide header and footer #57
Conversation
@jan-molak, I keep requiring to rebase and patch up to keep this current. Is there a problem with integrating it? |
Hey @drekbour, sorry for not giving you my feedback earlier; |
As js is not my forte, I'd rather leave toaster pop ups to those who could do so easily. Fair enough on the reduction in function though - I expect it's easy to make the footer visibility also conditional on the error being activated though... |
Resolved. |
@jan-molak bump. I'm trying to clear my dev backlog for the year so let me know if there is anything further to do here! |
<input data-ng-model="settings.showHeader" | ||
data-ng-false-value="0" | ||
data-ng-true-value="1" | ||
id="settings-colour-blind" type="checkbox" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This 'id' is a copy/paste error and should be 'settings-show-header'.
For the |
@jan-molak, I keep requiring to rebase and patch up to keep this current. Is there a problem with integrating it? It's a year old now! |
@jan-molak, I've rebased this again. Can you please review and integrate (or say why you don't like the feature) - it's been ~20 months now. |
Hi @drekbour and apologies for not getting back to you sooner. I think that the underlying problem here is that Build Monitor didn't cope very well with a large number (hundreds) of projects displayed on one screen - as depicted on the screenshot attached to #124. Having said that, many thanks for your pull request. It served as a valuable reminder that the problem needed to be addressed. It also highlighted that the UI required a bit of a rework to make it more flexible and capable of supporting busy Jenkins installations, such as yours. I've incorporated suggestions from yourself, @saan800 (#124) and @davidparsson (#165) and came up with a number of changes to the UI that should hopefully address the points you guys have raised. If you have a moment, I'd be grateful if you could download the latest build, try it out and let me know your thoughts! All the best, |
I tried the latest build and it's fine but I can't comment on the efficacy for large volumes as our usecase is not "200 jobs". We resolved that one years ago by allowing the use of filters from the ListView so it can monitor failed/building jobs only. We have many more usecases speaking to why screen real-estate matters:
I worry point 4 (the only one that really matters) is clashing with some other concern? |
Cookie-based checkbox added to settings panel which hides the header and footer
(now rebased onto master to include similar work on a colour-blind checkbox)
Closes #38