Refactor build card into extensible class #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all "Build Card" display and trigger logic into a BuildCardExtension class. This allows plugins or other BuildCardExtension children to customize behavior, for example to require approval notes
Conflicts: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/extension/PipelineHeaderExtension.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java
…e upstream project
This is a bit anathema to using handlebars but we're more or less stuck with it: provide a way for a BuildCardExtention to contribute JS to the build card, allowing for richer build cards. Also switched an appendTo() to an append() which during testing did an evaluation of the JS but only when it was in progress - this would result in build cards being hidden if the build is in progress. jQuery docs say these are equivalent, but they are liars.
…e upstream project
[Fixed JENKINS-23532] Search Folders when trying to find upstream project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows tickets like Jenkins-38670 to be solved -- make individual build cards customizable in your own plugin (or as another provided build card)