Run button parameterized builds #56
Conversation
… for a pipeline that starts with a parameterized build
|
I didn't explicitly run checkstyle and the build failed. I will update. |
|
Checkstyle issues fixed, apologies for that. |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
this is a killer for me.. would love to see this merged and a new release cut |
|
It looks like the following issues were either duplicated by the original issue or will also be fixed by this PR https://issues.jenkins-ci.org/browse/JENKINS-19121 |
|
looks ok for me |
|
Does it also fix #57 case ? |
|
Yes, it should.
|
|
@jeffastorey I promise @KostyaSha I'll do a review + test later tonight. Quick glance at it though LGTM. |
|
Please merge this and provide a new version, really missing the possibility to define the parameter for the first job |
|
@tompson while @christ66 reviewing please install hpi to your jenkins, test and reply "https://jenkins.ci.cloudbees.com/job/plugins/job/build-pipeline-plugin/149/org.jenkins-ci.plugins$build-pipeline-plugin/" |
|
@KostyaSha installed the snapshot, tested it and it works for me as expected |
|
Thanks, i will ping @christ66, then merge and release. |
Run button parameterized builds
|
@tompson please test it using Folders plugin with jobs in folder. |
|
I remembered! @christ66 wanted to test Folders support. We need test it before doing release. |
|
It should work with folders. I tested with and without. But a double
|
|
tested, works. |
|
released as 1.4.5, will appear on mirrors in next 24h. Atm you can update manually using hpi and plugin manager http://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/build-pipeline-plugin/1.4.5/ |
| @@ -63,7 +63,7 @@ | |||
| {{#unless project.disabled}} | |||
| <div class="status-bar" id="status-bar-{{id}}"> | |||
| {{#if build.isBuilding}} | |||
| <div class="pointer" onclick="buildPipeline.fillDialog('${rootURL}/{{build.url}}console', 'Console output for {{project.name}} #{{build.number}}')"> | |||
| <div class="pointer" onclick="buildPipeline.fillDialog('${app.rootUrl}{{build.url}}console', 'Console output for {{project.name}} #{{build.number}}')"> | |||
There was a problem hiding this comment.
If you are not ultimately inside <l:layout>, you can also use
<j:new var="h" className="hudson.Functions"/>
${h.initPageVariables(context)}
to initialize standard variables such as rootURL.
There was a problem hiding this comment.
Is it documented somewhere? Is there an analogue to Groovy?
There was a problem hiding this comment.
Normally you do not think about this because normally you would be inside l:layout which already sets this up for you.
|
I'm still facing problems to start pipelines with parameterised jobs. I'm using 1.4.8 and Jenkins 1.609.1 Following this (https://issues.jenkins-ci.org/browse/JENKINS-25427?focusedCommentId=237769&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-237769) I managed to solve the problem. @jeffastorey would you consider changing the current version o fancybox used in the plugin? I changed it to the patched version (https://github.com/prdolmos/fancybox-1.3.4-patched-for-jquery-1.9) above and to official version 2.1.5 (http://fancyapps.com/fancybox/). Worked fine in both cases. |
|
Can you submit a pull request for it? Ir sounds like you've already got it worked out. I'm not the maintainer though so I won't be the one to approve it. |
|
Will submit it. I was just asking because the ticket is resolved, but I Tks
|
In its current version 1.4.8, the plugin is unable to start a pipeline which the first job is pamateterised. It was possible on version 1.4.3 and according to jenkinsci#56 t should be possible again, but I only managed to run pipelines changing the version o Fancybox to 1.3.4_patch as recommended here: https://issues.jenkins-ci.org/browse/JENKINS-25427
|
@lonefreak did you make a PR? I am also suffering this problem and would love to see it fixed |
Fixes issues relating to the run button for parameterized builds
https://issues.jenkins-ci.org/browse/JENKINS-20841
https://issues.jenkins-ci.org/browse/JENKINS-25427
Also switched to using
app.rootUrlfor thefillDialogmethod as recommended by the jelly guidelines (https://wiki.jenkins-ci.org/display/JENKINS/Basic+guide+to+Jelly+usage+in+Jenkins#BasicguidetoJellyusageinJenkins-PredefinedURLs). Newer versions of Jenkins changedrootUrlto be/jenkinsand when the extra/was added byfillDialog, the URL did not work. Jenkins will automatically add the trailing slash to theapp.rootUrl