[FIXED JENKINS-19826] - Refactored percentage configuration approach. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix is not very graceful, but it also resolves issue with non-standard percentage timeouts. Probably, MAX limit should be changed... Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
ghost
assigned 
|
This patch resolves JENKINS-19826 only for a single plugin. BTW, seems that fix should e done on the core's level |
|
@oleg-nenashev can this be closed unmerged? It seems to be fixed in Jenkins core - right? |
|
I am of the opinion that this PR should be closed un-merged, as the matter should be and appears to have been resolved at the core level of Jenkins instead of at the individual plugin level. |
|
@darxriggs Thanks for the comment at #16 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for review... Is this change applicable or should I restore f:select?
Fix is not very graceful, but it also resolves issue with non-standard percentage timeouts. Probably, MAX limit should be changed...
Signed-off-by: Oleg Nenashev nenashev@synopsys.com