Add capturing checks publisher, make publishChecks withChecksName aware

[mrginglymus]

Addresses #54

[timja]

I would just extract the output to a variable and chuck and orElseThrow instead of .get

[mrginglymus]

That'll be a lot of orElseThrows! Might make it a bit less readable.

[mrginglymus]

Is there a way to shift this code into the checks-api-tests.jar to neaten up the production jar?

[XiongKezhi]

Is there a way to shift this code into the checks-api-tests.jar to neaten up the production jar?

Do we have any other places that need it?

[timja]

Is there a way to shift this code into the checks-api-tests.jar to neaten up the production jar?

There's a few plugins that ship jars for this under the classifier 'tests' jcasc used to, and some of the pipeline ones do, search the bom for the tests classifier: https://github.com/jenkinsci/bom

[uhafner]

Is there a way to shift this code into the checks-api-tests.jar to neaten up the production jar?

Yes, just move the code to the tests folder and add an inclusion to the pom, see example. Custom assertions are already picked up by the test jar.

[mrginglymus]

Is there a way to shift this code into the checks-api-tests.jar to neaten up the production jar?

Do we have any other places that need it?

It's only needed in tests, but it will be useful for testing in the consumers (I'm adding some details to consumers-guide.md) such as junit, where I originally added this. I was going to add support to withChecks to some of the other consumers but realised it would be a lot easier with this!

[timja]

I would add the link from the javadoc here as well,

to io.jenkins.plugins.checks.steps.PublishChecksStepITest

[uhafner]

Typically, one would use in AssertJ:

Suggested change

	assertThat(details.getName().get()).isEqualTo("customized-check");
	assertThat(details.getName()).isPresent().get().isEqualTo("customized-check");

This will also not require the annotation.

[mrginglymus]

Oh, neat! Thanks.

[XiongKezhi]

For better grammar

Suggested change

	String checksName = Optional.ofNullable(Util.fixEmpty(step.getName())).orElse(
	StringUtils.defaultIfEmpty(step.getName(),
	Optional.ofNullable(getContext().get(ChecksInfo.class))
	.map(ChecksInfo::getName)
	.orElse(StringUtils.EMPTY))

[mrginglymus]

New mystery - why is the Windows build hanging between reporting integration test results and running the run-revapi step...

[XiongKezhi]

New mystery - why is the Windows build hanging between reporting integration test results and running the run-revapi step...

Not a big deal, there are always some problems with the windows build on our community ci (due to resources and so on); normally I only take a look at the github builds and the linux build on the community server.

[jglick]

@XiongKezhi this is normally accomplished just with

<no-test-jar>false</no-test-jar>

For some reason you are inheriting from analysis-pom, which does things differently, rather than directly from org.jenkins-ci.plugins:plugin.