Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoggingChecksPublisher and tests for status checks #59

Merged
merged 4 commits into from
Dec 23, 2020

Conversation

XiongKezhi
Copy link
Contributor

The logging checks publisher is still needed for status checks test besides capturing details publisher since we cannot verify the details of the checks in the middle of a build.

@XiongKezhi XiongKezhi self-assigned this Dec 22, 2020
@XiongKezhi XiongKezhi linked an issue Dec 22, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #59 (5f31550) into master (6182093) will increase coverage by 5.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
+ Coverage     77.97%   83.79%   +5.82%     
- Complexity       75       78       +3     
============================================
  Files            14       14              
  Lines           395      395              
  Branches         16       16              
============================================
+ Hits            308      331      +23     
+ Misses           82       58      -24     
- Partials          5        6       +1     
Impacted Files Coverage Δ Complexity Δ
...ins/plugins/checks/api/ChecksPublisherFactory.java 89.47% <0.00%> (+5.26%) 9.00% <0.00%> (+1.00%)
...gins/checks/status/BuildStatusChecksPublisher.java 66.17% <0.00%> (+32.35%) 5.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6182093...5f31550. Read the comment docs.

@XiongKezhi XiongKezhi requested a review from a team December 22, 2020 16:49
@XiongKezhi XiongKezhi merged commit 6d41c27 into master Dec 23, 2020
@XiongKezhi XiongKezhi deleted the add_test_for_status_checks branch December 23, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add publisher for test.
2 participants