Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69966] Use string as alt text for icon (Jenkins 2.375 fix) #30

Merged
merged 3 commits into from Nov 5, 2022

Conversation

timja
Copy link
Member

@timja timja commented Oct 28, 2022

JENKINS-69966 Use string as alt text for icon (Jenkins 2.375 fix)

Needs to be a string, this is straight passing through from a health report score which is an int.

I think this would work fine in jelly because it would just translate to a string. but groovy has kept the typing.

Verified locally that this works properly

@timja timja added the bug For changelog: Minor bug. Will be listed after features label Oct 28, 2022
@timja timja force-pushed the JENKINS-69966-new-weather-broken branch 2 times, most recently from 9b4fcb4 to 04b10e6 Compare October 28, 2022 11:09
@timja timja force-pushed the JENKINS-69966-new-weather-broken branch from 04b10e6 to 89fef0c Compare October 28, 2022 13:03
@MarkEWaite MarkEWaite merged commit e3d8435 into jenkinsci:master Nov 5, 2022
@timja timja deleted the JENKINS-69966-new-weather-broken branch November 5, 2022 19:45
@MarkEWaite MarkEWaite changed the title JENKINS-69966 Fix plugin on 2.375 [JENKINS-69966] Fix plugin on 2.375 Nov 5, 2022
@MarkEWaite MarkEWaite changed the title [JENKINS-69966] Fix plugin on 2.375 [JENKINS-69966] Use string as alt text for icon (Jenkins 2.375 fix) Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants