Added Project Naming Strategy check to existing folder names #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plugins » cloudbees-folder-plugin #28 FAILURE |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| } | ||
| } finally { | ||
| // Reset project naming strategy so other tests don't fail! | ||
| jenkins.setProjectNamingStrategy(ProjectNamingStrategy.DEFAULT_NAMING_STRATEGY); |
There was a problem hiding this comment.
Probably unnecessary, since each test gets its own jenkins.
|
On the right track but not quite right. Also would probably need to be backported to a 4.2.x branch (not yet created) for compatibility with older Jenkins cores. Will try to rework this soon. |
|
plugins » cloudbees-folder-plugin #29 FAILURE |
jglick
changed the title
jglick
changed the title
|
Ancient. Please comment if you want to pick up the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Project Naming Strategy only works for Jobs when force existing is true. This pull request enables the Project Naming Strategy when forced enabled is enabled.