Nitpicking #1
Merged
Nitpicking #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because it contains references to the transient objects like a channel connection to a slave. So at minimum the field needs to be marked 'transient'. Builder can be also shared across multiple builds, so the best thing to do in this case is not to store this state in the field. There's an up-to-date check inside the performInstallation method so that this lack of caching shouldn't really result in a notcable performance degradation.
If the variable references are used inside the setting, they will cause the validation to fail and issue a false positive warning, and that'd be confusing. I'm fixing this in FilePath.validateFileMask, but in the mean time a workaround is implemented in a plugin.
ghost
assigned 
|
Thanks Kohsuke. I'm merging, but can you elaborate on this part?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark found out a few glitches in the plugin. These two changes eliminate them.
The first commit is a bit more serious in that it will interfere with the correctness of the plugin when it's used in a certain project type, such as a Maven project. It also prevents the job configuration from getting updated programmatically (although this isn't probably too common.)
The second commit removes a rough edge where a form validation is too eager and issue a big warning where it shouldn't.