Add total line count to coverage paint for programmatic usage

[beamerblvd]

As Jenkins Pipeline scripts are becoming more prevalent, programmatic usage of plugin results will become more common. In this case, the result of the Cobertura plugin invocation in the pipeline can be used to feed other plugins, or published to code review systems. In support of such ends, CoveragePaint was missing a bit of information: The total number of lines in the file, including non-executable lines. Absent this, our code is having to re-open and re-read every line of every source file which the SourceCodePainter has already opened and read, just to count the total number of lines to send to our code review system along with the coverage paint information. This simple change eliminates the duplicate file reading and makes the Cobertura results more usable in a programmatic way.

NOTE: I had planned to file a feature request for this and THEN submit the pull request for it, but the issue tracking system flagged me as spam and I am still waiting on someone to review it.

[jeffpearce]

I want to make sure I understand correctly. This doesn't affect the existing report, but makes the plugin more useful to other plugins? Can you add at least one simple test, even if it's just get/set. Sounds trivial, but it would help make sure a future maintainer doesn't accidentally break it.

[beamerblvd]

That's exactly correct, Jeff. I can add a test when I get home from work tonight. Is src/test/java/hudson/plugins/cobertura/targets/CoveragePaintTest.java the correct location for such a test?

[jeffpearce]

Seems like a good place. Thanks for the PR, BTW

[beamerblvd]

Alright, Jeff. I added a test and some asserts to the existing test, and the build passed. I believe it's ready to merge if you're good with it.

[jeffpearce]

Thanks again for the PR!