-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use color for unchanged coverage #777
Comments
@uhafner Hello !!! |
There are basically two things to implement: This code needs to be changed on the UI side: code-coverage-api-plugin/plugin/src/main/resources/coverage/coverage-summary.jelly Line 63 in 9804fdb
And this is the model on the server side: Line 550 in 9804fdb
I would suggest to change that method to something like
It makes sense to use rounding in the server method so that |
Hello!! coverage-summary.jelly file - Can you help me out in writing the test case of this function, mainly what values of |
Can you please create a draft pull request? Then I can write comments in the diff.
It makes no difference which metric or baseline you are using. Create a new action (see some other tests on how to do that) with some percentages. Then you can call the method. |
The isPostiveTrend() is changed to getTrend() and corresponding file changes are made as per the PR - Do not use color for unchanged coverage jenkinsci#777
Hello !!! I have made the changes and added some test cases for review. |
Some changes are made again as per the feedback in the draft PR Do not use color for unchanged coverage jenkinsci#777
This is regarding the PR Do not use color for unchanged coverage jenkinsci#777
Do not use color for unchanged coverage #777
When the coverage delta is zero, then no coloring should be applied to the text.
The text was updated successfully, but these errors were encountered: