Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additionalProperty to istanbul-cobertura-to-standard.xsl to keep … #136

Conversation

afkbrb
Copy link
Contributor

@afkbrb afkbrb commented Jan 18, 2020

I added additionalProperty support to istanbul-cobertura-to-standard.xsl according to cobertura-to-standard.xsl.
Also, I made corresponding changes to IstanbulCoberturaReportAdapter to enable it to handle additionalProperty.
After these two changes, the embeded istanbul-cobertura adapter can now find out where source file path is according to the coverage/sources/source property in coverage.xml (the report file for cobertura).

Copy link
Contributor

@cizezsy cizezsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cizezsy cizezsy merged commit 6b6269f into jenkinsci:dev Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants