Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show an icon in checks report when the coverage did not change #665

Merged
merged 3 commits into from
May 10, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented May 8, 2023

Fixes #662

@uhafner uhafner added the bug Bugs or performance problems label May 8, 2023
@uhafner uhafner changed the title So not show an icon in checks report when the coverage did not change Do not show an icon in checks report when the coverage did not change May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #665 (be43693) into master (e486bea) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #665      +/-   ##
============================================
- Coverage     73.55%   73.55%   -0.01%     
  Complexity     1663     1663              
============================================
  Files           129      129              
  Lines          6240     6236       -4     
  Branches        668      667       -1     
============================================
- Hits           4590     4587       -3     
+ Misses         1431     1430       -1     
  Partials        219      219              
Impacted Files Coverage Δ
...s/plugins/coverage/metrics/steps/PathResolver.java 65.47% <ø> (ø)
...overage/metrics/steps/CoverageChecksPublisher.java 93.10% <75.00%> (+0.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uhafner uhafner merged commit af39962 into master May 10, 2023
24 of 25 checks passed
@uhafner uhafner deleted the remove_zero_icon branch May 10, 2023 18:41
@uhafner uhafner added enhancement Enhancement of existing functionality and removed bug Bugs or performance problems labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checks publisher should not use arrow up when there are no changes
1 participant