Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-66708] Modernize config-file-provider icons #215

Merged
merged 2 commits into from
Jul 20, 2022
Merged

[JENKINS-66708] Modernize config-file-provider icons #215

merged 2 commits into from
Jul 20, 2022

Conversation

bzzitsme
Copy link
Contributor

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did

PR for https://issues.jenkins.io/browse/JENKINS-66708
C-F-G icon was changed to
cfg-logo

If you have any suggestions or questions regarding PR, I will be happy to hear/answer them.

We could also use this icon instead of one that is in the PR:
file-copy

alecharp
alecharp requested changes Jul 20, 2022
View reviewed changes
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I tested it locally and it was working fine.
Could you just update the jenkins.version to keep referencing to an LTS? Thanks.

pom.xml Outdated Show resolved Hide resolved
@alecharp alecharp requested a review from jmMeessen July 20, 2022 11:44
@alecharp alecharp changed the title Modernize config-file-provider icons [JENKINS-66708] Modernize config-file-provider icons Jul 20, 2022
@bzzitsme bzzitsme requested a review from alecharp July 20, 2022 13:55
@jmMeessen jmMeessen merged commit 121357a into jenkinsci:master Jul 20, 2022
jmMeessen
jmMeessen reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@jmMeessen jmMeessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmMeessen
Copy link
Contributor

Thank you for the pull request @bzzitsme. Merged it and cutting a release

@NotMyFault
Copy link
Member

NotMyFault commented Jul 20, 2022 •
edited
Loading

The proposed symbol doesn't honor the API and is not themable, yet it implies to be, considering it landed in the symbol folder.

@bzzitsme
Copy link
Contributor Author

is not themable

Do you mean dark theme plugin?

@NotMyFault
Copy link
Member

NotMyFault commented Jul 20, 2022 •
edited
Loading

is not themable

Do you mean dark theme plugin?

In any theme plugin. The API looks for currentColor values in common attributes like stroke, fill, etc. used to theme SVGs.
If none is present, Jenkins can't apply a theme and the symbol API fails.

@NotMyFault NotMyFault mentioned this pull request Jul 20, 2022
Merged
@bzzitsme
Copy link
Contributor Author

@NotMyFault I wanted to propose PR, but you already did it, thanks a lot!
Completely forgot about themable compatability.

@NotMyFault
Copy link
Member

I just noticed this PR, because I got a mail sent by my Jira issue. But that's what I had in mind when reviewing the core PR.
I'm not sure if that is stated somewhere, if not, I'll write something up.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmMeessen jmMeessen jmMeessen left review comments

@alecharp alecharp alecharp approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzzitsme @jmMeessen @NotMyFault @alecharp